zookeeper-operator icon indicating copy to clipboard operation
zookeeper-operator copied to clipboard

[Enhancement] Implement automatic backup

Open ibumarskov opened this issue 2 years ago • 4 comments

Description

Automatic backup of zookeeper db is a useful mechanism in demand in many real-world scenarios. It would be great to implement a separate controller responsible for automatic backup by schedule or on-demand backups. As the simplest implementation we can provide backup of ZooKeeper by copying its transaction and snapshot logs. It's a reasonable method, there is a short article regarding backup/restore procedure for zookeeper: Apache ZooKeeper Backup, a Treatise

Importance

Should-have

Location

Zookeeper operator.

Suggestions for an improvement

Separate controller can be added to watch for a new type of resource (zookeeper-backup for example). Controller should take following responsibilities:

  • Provide cluster health check and cancel backup operation if required.
  • Detect ZK leader pod and prepare/reconfigure CronJob configuration (Backup pod should land on node where leader is elected).
  • Schedule CronJob with a backup script.
  • Provide mechanism to periodic checks to make sure CronJob configuration is updated and valid (for example in case of new leader election)

Backup script should contains following steps:

  1. May contain some additional checks (for example check that it really landed on pod with leader, check datadir folder exists, check free storage space, etc.)
  2. Create archive of datadir folder and put it in a backup folder (It should be a volume intended for storage backups)
  3. Check amount of backups and delete oldest if necessary (should be specified in zookeeper-backup cr)

ibumarskov avatar Oct 22 '21 09:10 ibumarskov

CreateVehicle now use a array instead of vec3 for coords

CeebDev avatar Mar 06 '24 23:03 CeebDev

CreateVehicle now use a array instead of vec3 for coords

It should accept an array, map, or vector.

thelindat avatar Mar 07 '24 00:03 thelindat

It should accept an array, map, or vector.

Then it's a problem, when i log coord it return a buffer and vehicle spawn at 0, 0, 0

This is related : forum.cfx.re/t/lua-vectors-dont-serialize-to-arrays-through-events/4772780/2

CeebDev avatar Mar 07 '24 12:03 CeebDev

Ox.GetPlayerByFilter is replaced by Ox.GetPlayerFromFilter

CeebDev avatar Mar 09 '24 20:03 CeebDev