Internship-LMS-FrontEnd icon indicating copy to clipboard operation
Internship-LMS-FrontEnd copied to clipboard

Integrate Netlify for Deploy Previews

Open praveenscience opened this issue 4 years ago • 29 comments

As we move up to the coding phase now, let's start implementing the Deploy Previews feature of Netlify. When someone creates a PR, the netlify service should send a link to show how it looks.

You can find more information here: Introducing Deploy Previews in Netlify. This is up for grabs people. Anyone from DWoC or SWoC can pick it up.

When you pick up, please answer the following in bullet points as answers:

  • Do you understand what is required? Do you need any help with the issue?
  • How much Netlify integration knowledge you have? You wanna try or you know it and you wanna work?
  • Which programme you're working on? DWoC or SWoC or both?

As always, reach out to me in case of anything. 😁

praveenscience avatar Jan 26 '21 07:01 praveenscience

Hi, can I work on this?

Do you understand what is required? Do you need any help with the issue?

Yes, it is essentialy setting up a CICD for the application

How much Netlify integration knowledge you have? You wanna try or you know it and you wanna work?

I haven't done much with Netlify but I have worked with other hosting services. I want to learn doing it on Netlify and will do so.

Which programme you're working on? DWoC or SWoC or both?

I am working on DWoC

Can you please assign this to me?

avinashupadhya99 avatar Jan 26 '21 10:01 avinashupadhya99

Hi @avinashupadhya99, yes, technically it's setting up CI/CD for only the PRs... 😁

Can you please assign this to me?

Cool, you can start working on this. 😁 Keep me updated with the progress.

praveenscience avatar Jan 26 '21 10:01 praveenscience

Hey, I looked up deploy previews on Netlify and tested it out with my repo. There are no code changes necessary for deploy previews. Once the repository is set up for deployment on Netlify, any PR made to the repository will have a deploy preview. There are no changes required.

Please let me know if you plan on implementing CICD for the entire application. I can work on that. 🥂

avinashupadhya99 avatar Jan 28 '21 04:01 avinashupadhya99

Yes, @avinashupadhya99. What needs to be done? Should we do it together?

Just saw this: You only need to add commit hooks to your Netlify sites, we take care of the rest.

praveenscience avatar Jan 28 '21 13:01 praveenscience

@avinashupadhya99 I'll set this thing up. Once I have done it, I'll ask you to update some code changes so that you get the points for looking into. Hope that helps?

praveenscience avatar Jan 28 '21 13:01 praveenscience

You only need to add commit hooks to your Netlify sites, we take care of the rest.

Yes you just need to add the repository on Netlify. Everything else is taken care by them.

@avinashupadhya99 I'll set this thing up. Once I have done it, I'll ask you to update some code changes so that you get the points for looking into. Hope that helps?

No issue. I will work on other issues that come up

avinashupadhya99 avatar Jan 28 '21 14:01 avinashupadhya99

@avinashupadhya99 This one is still your responsibility. Thanks for getting me a clarity on this. 😁 Will award the right points for you.

praveenscience avatar Jan 29 '21 08:01 praveenscience

I'm sorry, I didn't get it. Should I set up the netlify on my account? If yes, I don't think that is possible because I would need access to the repository.

If it is regarding the points for DWoC, I'm fine with it. 😄 I got to learn something new. 😁

avinashupadhya99 avatar Jan 29 '21 09:01 avinashupadhya99

@avinashupadhya99 Send a random PR to fix something. I'll get you the points you deserve. Can you please do it now?

praveenscience avatar Feb 26 '21 09:02 praveenscience

@praveenscience and @avinashupadhya99 , i have worked with netlify CI, i might help you both. infact my all website are netlify deployed.

Uyadav207 avatar Mar 10 '21 18:03 Uyadav207

@Uyadav207 Sure, let's jump on a call.

praveenscience avatar Mar 11 '21 15:03 praveenscience

@satyampandeygit Did you message something here?

praveenscience avatar Mar 19 '21 19:03 praveenscience

@praveenscience as it is the admin who needs to link his repo to his own netlify credentials, should I close this issue?

ampsteric avatar Mar 24 '21 17:03 ampsteric

@ampsteric Once I do it, let's close it. I'll self-assign it to myself.

praveenscience avatar Mar 24 '21 18:03 praveenscience

please assign this to me

subhangi2731 avatar Apr 26 '21 06:04 subhangi2731

@subhangi2731 I have assigned it to you.

praveenscience avatar Apr 26 '21 09:04 praveenscience

I want to work on this

gargijs avatar May 07 '21 17:05 gargijs

I want to fix this, please assign me.

Abhishekkr93 avatar May 07 '21 17:05 Abhishekkr93

Let's meet on Monday to check the status of this:

  • @subhangi2731 (It's been 12 days and no response)
  • @gargijs (You have time till Monday!)
  • @Abhishekkr93 (You have time till Monday!)

praveenscience avatar May 07 '21 21:05 praveenscience

Okay sir. @praveenscience

Abhishekkr93 avatar May 07 '21 22:05 Abhishekkr93

@praveenscience I will make a pr by today

subhangi2731 avatar May 10 '21 04:05 subhangi2731

Sorry I had exams in my college @praveenscience

subhangi2731 avatar May 10 '21 04:05 subhangi2731

Okay thanks, let me know the progress folks! 🔥

  • @subhangi2731 (any updates?)
  • @gargijs (any updates?)
  • @Abhishekkr93 (any updates?)

praveenscience avatar May 10 '21 09:05 praveenscience

Any updates folks? By tomorrow, if there's no activity, I am happy to do it myself and implement this... 🔥

praveenscience avatar May 10 '21 16:05 praveenscience

We're taking this on Live Stream and making it work! 🔥 Thanks everyone for all your efforts. 😊 Please let's meet on the Live Stream to know how this is done. 👍

praveenscience avatar May 11 '21 07:05 praveenscience

@subhangi2731 Since you messaged me, would you like to collaborate with me on the Live?

praveenscience avatar May 11 '21 07:05 praveenscience

Can I try solving this issue?

vave4 avatar Aug 25 '21 13:08 vave4

Yes, sure @vave4

praveenscience avatar Aug 25 '21 13:08 praveenscience

Any updates @vave4?

praveenscience avatar Oct 04 '21 17:10 praveenscience