graph icon indicating copy to clipboard operation
graph copied to clipboard

a bug?

Open jie-huangfu opened this issue 4 years ago • 3 comments

in the file include/graph/detail/directed_adjacency_vector_impl.hpp, line 908:

const auto& [ukey, vkey, uv_val] = edge_data;

the uv_val should be removed, as the tuple edge_data has only 2 elements.

jie-huangfu avatar Sep 18 '21 02:09 jie-huangfu

another one, in the same file, line 1403:

the constructor for "edge_type" is wrong

should remove line 1401-1403, and just use: edges_.emplace_back(edge_type(from_key, to_key));

jie-huangfu avatar Sep 18 '21 15:09 jie-huangfu

also, this file probably should include the header file <limits> or g++ ( version 11) will complain about numeric_limits<unsigned int>::max()

jie-huangfu avatar Sep 18 '21 15:09 jie-huangfu

I appreciate your looking at the details. There are some potential major changes to the whole API, so I don't want to put much time into this at the moment. It's hard to say how long it will take - we have a CppCon talk to prepare for and I have a long break also.

pratzl avatar Sep 19 '21 20:09 pratzl