Michael Pratt
Michael Pratt
FWIW, this did not seem to fix the benchmark: https://perf.golang.org/dashboard/?benchmark=AppendMsgReplicateDecision-8&days=90&end=2022-10-28T15%3A45 The most recent run is for https://go.dev/cl/444715, which was submitted after https://go.dev/cl/445875.
IIRC @amscanne changed tests to all run together in one sandbox, so I'm not sure what the current filtering incantation is. That said, this test is fundamentally flaky: https://cs.opensource.google/gvisor/gvisor/+/master:test/syscalls/linux/tcp_socket.cc;l=506-518?q=tcp_socket.cc:510&ss=gvisor%2Fgvisor If...
cc @amscanne FYI, gcflags `-N -l` disables most optimizations and inlining, which (unsurprisingly) tends to increase stack usage. Typically this used with debuggers to provide more precise debugging context (fewer...
In theory, we do have a warning: https://github.com/google/gvisor/blob/master/pkg/sentry/memutil/memutil_unsafe.go#L34 I know the plumbing all the way up to the Docker CLI worked when that was added, but it must have regressed...
Hi, I just discovered this project and it looks like an amazingly useful tool, and I'd love to get it working better with Go. I haven't tried running myself yet,...
This trace looks quite good. It doesn't have many preemptions to look at. I'll probably need to look at a different program, though I don't have time at the moment....
re https://github.com/nodejs/docker-node/issues/1158#issuecomment-557410925: The stack size issue crash from https://github.com/nodejs/docker-node/issues/813#issuecomment-407322127 is fixed in Node in https://github.com/nodejs/node/commit/5539d7e360a625e729a4f95e67d232d3400fc137 (I ran a bisect), which is included in v13, but not v10. A related libuv...
Maybe? It's hard to say. FWIW, both of the failures above were on the same (non-MacService) machine.
cc @rsc This seems to be one of our flakiest tests. I'm getting multiple failures within the tests on an 8 CL stack.