Michael Pratt

Fix in https://github.com/google/pprof/pull/717

cc @golang/release This would be nice to have in 1.19 or 1.19.1 (arguably backported to 1.18 too), but I am not sure we want to pull this in so close...

This isn't going to make it into 1.19, but we can consider it for 1.19.1 (I'm personally still a bit unsure since there is a workaround).

@gopherbot Please backport to 1.19. This fix just barely missed 1.19. While it does have a workaround (use upstream pprof instead of go tool pprof), that is unlikely to be...

Sure, I can do so. Do we have a standard process for backporting one-off fixes to vendored packages, rather than wholesale updates? I can easily manually apply the appropriate changes...

I don't see any such similar cases on https://go-review.git.corp.google.com/q/project:go+is:merged+file:vendor+-branch:master+-branch:dev.link+-branch:dev.boringcrypto+-branch:dev.typeparams+-branch:dev.fuzz. :( A full update of pprof on release-branch.go1.18 will pull in 20 commits: ``` $ git log --oneline f987b9c94b31..154dc81eb7b0 154dc81 all:...

I can take a closer look tomorrow, but I don't think there are any technical blockers (or any changes to non-vendored code required) to updating pprof to `v0.0.0-20220729232143-a41b82acbcb1` in 1.18,...

@gopherbot Please backport to 1.18. While it does have a workaround (use upstream pprof instead of go tool pprof), that is unlikely to be clear to users.

@kuabhish @vignesh-codes Do either of you have a reproducer you can share?

Everything I expect to get into 1.19 is in. Moving future work to 1.20.