Michael Pratt

icon indicating a website link http://michael.pratt.im

icon company @google icon location New York, NY icon location Building Go and gVisor @google. He/him. 🏳️‍🌈

Results 235 comments of Michael Pratt

cmd/go,cmd/link: TestScript/build_issue48319 and TestScript/build_plugin_reproducible failing on LUCI gotip-darwin-amd64-longtest builder due to non-reproducible LC_UUID

Based on the otool output, it looks like this other component is the `LC_UUID` value: `EDFB2D7D-AB6E-374D-8EBA-7C75012CC264` vs `F0CB7393-B5BD-3B76-9FB5-5F03DD324C8A`. I don't know MachO very well, but it seems that this is...

cmd/go,cmd/link: TestScript/build_issue48319 and TestScript/build_plugin_reproducible failing on LUCI gotip-darwin-amd64-longtest builder due to non-reproducible LC_UUID

The output of `GODEBUG=gocachehash=1` is identical for both builds.

cmd/go,cmd/link: TestScript/build_issue48319 and TestScript/build_plugin_reproducible failing on LUCI gotip-darwin-amd64-longtest builder due to non-reproducible LC_UUID

Thanks for the reference! Looking at the `go build -x` output, the last few steps are: ``` GOROOT_FINAL='$GOROOT' /Volumes/Work/s/w/it_9mfvcff/workdir-swarming-task/go/pkg/tool/darwin_amd64/link -o a.out.so -importcfg $WORK/b001/importcfg.link -installsuffix dynlink -pluginpath plugin/unnamed-bf82aa353b25c4b8a6ab19fdb37f3d07a25be28e -buildmode=plugin -buildid=LB6Hzd7kl1bXrnyHizXY/p-z89AF5Na6o1snDfpJh/6Dt_ODGiuqE-vRNRx1Xx/LB6Hzd7kl1bXrnyHizXY -extld=clang...

cmd/go,cmd/link: TestScript/build_issue48319 and TestScript/build_plugin_reproducible failing on LUCI gotip-darwin-amd64-longtest builder due to non-reproducible LC_UUID

It doesn't seem to be related to the file paths. cmd/link invokes clang like so: ``` host link: "clang" "-arch" "x86_64" "-m64" "-Wl,-headerpad,1144" "-Wl,-flat_namespace" "-Wl,-bind_at_load" "-dynamiclib" "-o" "a.out.so" "-Qunused-arguments" "/Volumes/Work/s/w/it_9mfvcff/go-link-202179431/go.o"...

cmd/go,cmd/link: TestScript/build_issue48319 and TestScript/build_plugin_reproducible failing on LUCI gotip-darwin-amd64-longtest builder due to non-reproducible LC_UUID

Perhaps, but I'd like to better understand what is happening. Plus it seems like some users may want the UUID, as Chrome did. FWIW, the `clang` command consistently generates identical...

cmd/go,cmd/link: TestScript/build_issue48319 and TestScript/build_plugin_reproducible failing on LUCI gotip-darwin-amd64-longtest builder due to non-reproducible LC_UUID

cc @thanm see https://github.com/golang/go/issues/64947#issuecomment-1875889679 for reproducer instructions

cmd/go,cmd/link: TestScript/build_issue48319 and TestScript/build_plugin_reproducible failing on LUCI gotip-darwin-amd64-longtest builder due to non-reproducible LC_UUID

FWIW, the version of Xcode we're installing is 15.0.0. I peeked at the release notes for 15.0.1 and 15.1 and nothing stood out as a fix for this kind of...

cmd/go,cmd/link: TestScript/build_issue48319 and TestScript/build_plugin_reproducible failing on LUCI gotip-darwin-amd64-longtest builder due to non-reproducible LC_UUID

FWIW, it looks like there are more [versions](https://chrome-infra-packages.appspot.com/p/infra_internal/ios/xcode/mac) of Xcode available to try out, though I haven't tested them: * `mac_toolchain install -xcode-version 15a240d`: 15.0 * `mac_toolchain install -xcode-version 15A507`:...

runtime/pprof: no API to access deep stacktraces with MemProfileRecord and BlockProfileRecord

cc @golang/runtime

runtime/pprof: better generic type information in pprof stack traces

Just brainstorming, but I think theoretically traceback could, upon encountering a type-parameterized function, look for the dictionary argument (assuming it is still live) and extracting the real type parameters. This...