Michael Pratt
Michael Pratt
gscan -> profInsert split to #64706.
@mknyszek I think adding `traceStackTab` above `WB` would be OK? Edit: oh, nevermind. I see #56554 now.
Thanks for the update. For what it's worth, I got this failure on https://go.dev/cl/564137 at around Feb 14, 6pm EST. It sounds like that may be after your latest change?...
That's a good question. I wonder how much disk this test used on the old infra. I know this test does generate an absolutely massive source file. cc @golang/release
cc @zzkcode (https://github.com/golang/go/issues/64650#issuecomment-1857902016) @srinivas-pokala Note that https://go.dev/cl/554615 is adjusting this behavior slightly, though I don't know if it will affect these failures. The failures do look concerning. e.g., in https://build.golang.org/log/526c7281403cbfa93b3aa016ec3281c2e487d7ec...
@bcmills Am I understanding correctly that you are saying that ultimately the test is failing because traceback reports `goroutine running on other thread; stack unavailable` for the running threads? If...
Update on this. I took a look at median, worst case, etc build times for the main repo builder by bot hostname and there definitely seems to be a lot...
I agree that this is a pain point and don’t have objections to this proposal. That said, it seems to me that the premise of this issue generalizes to any...
There is a small chance that #56424 is related, though it seems unlikely as that was at a much smaller scale.
Thanks for the details! I'll try to write a reproducer when I have some free time, not sure when I'll get to it. > it wasn't apparent there was a...