IoT-Spot icon indicating copy to clipboard operation
IoT-Spot copied to clipboard

Blink esp8266

Open adithya-s-k opened this issue 2 years ago β€’ 3 comments

Related Issue

  • Info about the related issue

  • [x] SSOC Participant

  • [ ] Contributor

Closes: #291 that will be closed through this PR

Describe the changes you've made

I have added blinking led for ESP8266

Type of change

What sort of change have you made:

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [x] New feature (non-breaking change which adds functionality)
  • [ ] Code style update (formatting, local variables)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [ ] This change requires a documentation update

How Has This Been Tested?

I have tested it on my ESP8266(Hardware)

Checklist:

  • [x] My code follows the guidelines of this project.
  • [x] I have performed a self-review of my own code.
  • [x] I have commented my code, particularly wherever it was hard to understand.
  • [x] I have made corresponding changes to the documentation.
  • [x] My changes generate no new warnings.
  • [x] I have added tests that prove my fix is effective or that my feature works.
  • [ ] Any dependent changes have been merged and published in downstream modules.

adithya-s-k avatar Aug 21 '22 09:08 adithya-s-k

Hello there! πŸ‘‹ Welcome to the project! πŸ’– Thank you and congrats πŸŽ‰ for opening your first pull request. Please adhere to our Code of Conduct. πŸ™ŒπŸ» We will get back to you as soon as we can. πŸ˜„

Feel free to get in touch with me through social media handles. Hope to see you there!πŸ˜„

welcome[bot] avatar Aug 21 '22 09:08 welcome[bot]

@prathimacode-hub the pull request has been approved can you please merge it.

adithya-s-k avatar Aug 22 '22 17:08 adithya-s-k

@mdnazisharman2803 @prathimacode-hub please look into merging this PR the review is already done

adithya-s-k avatar Aug 25 '22 14:08 adithya-s-k

@Harshil-Jani please look into the changes

adithya-s-k avatar Sep 05 '22 19:09 adithya-s-k

Congrats on merging your first Pull Request! πŸŽ‰ All the best for your amazing open source journey ahead. πŸš€βš‘οΈ

welcome[bot] avatar Sep 05 '22 19:09 welcome[bot]