Requesting fastlane

[IzzySoft]

I've just noticed two things with today's release of v2.0.0:

• the applicationId was changed. This means existing users will need to uninstall and re-install, so this should only be done when it cannot be avoided for good reasons (it's done now, but please take care not to repeat it too often :wink:)
• versionCode is still set to 1. Not a big deal this time, as applicationId was changed and thus this effectively became a new app – but for future updates this should be increased with each release, as that's how Android tells versions apart and decides which means an update.

For the latter, this line in your pubspec.yaml would need to be adjusted:

version: 2.0.0+1

would reflect the current release. Pattern is version: <versionName>+<versionCode>. For the next version, this could then look like

version: 2.0.1+2

Thanks for taking care!

[prateekmedia]

Thanks for your review, will now do +1 type versioning and yes the package id will not be changed now.

[prateekmedia]

I will try to add fast lane this week to make this Fdroid compatible.

[IzzySoft]

Great! If you let me know when it's there, I can activate it for my repo immediately.

[prateekmedia]

Sure

[prateekmedia]

Hi @IzzySoft, I followed https://docs.fastlane.tools/getting-started/android/setup/ and I have done till fastlane init in the android folder of this repo, and AppFile, FastFile have been generated. So is fastlane setup complete?

[IzzySoft]

Oof, no… The binaries are just needed if you want to use Fastlane to ship things to e.g. Play itself. I see you've changed the title of the issue, which is a bit confusing – requesting Fastlane, I would have pointed you to my Fastlane Cheat Sheet where you can find what is needed: F-Droid needs those metadata files, not the Fastlane binaries :wink:

[prateekmedia]

@IzzySoft can you check it now pls, also do I need to run the github action on every new commit or every new release?

Also I already have app icon and screenshots so it is creating duplicate entries in the repo so can I copy these files when running github actions or I have to keep the duplicate files in this repo?

[IzzySoft]

Looks good now! As I have no idea about Github actions, I cannot tell about that part. But feeding at each release (i.e. immediately before you tag) is fully sufficient, as it's only pulled with new releases (i.e. "what's at the tag") anyhow.

[prateekmedia]

@IzzySoft We are ready to rock!

[IzzySoft]

Looks like not yet fully: Today's release still has versionCode:1 – so while the app was updated in my repo for new installs, no existing users will notice as no update notice will be sent :cry: You must update pubspec.yaml before building the APK and tagging the release, not after, or your versions will be "one off".

Shit happens. And looks like you simply noticed too late. More luck next time :crossed_fingers:

But I see Fastlane is there – so let me do my part to make the next release a success, and set up configuration on my end to pull Fastlane along with your next release.

May I suggest to amend full_description.txt?

Ever wondered how the videos in the internet will look without ads, no more wondering just use PsTube.

* Beautiful user interface
* Lightweight and fast
* No Login Required
* Keep your liked videos and comments
* Playlists support
* Download videos, audios and thumbnails

(taken from the current description in my repo and merged with your current full_description.txt). I've just fetched everything else and, assuming you agree amending the description (on your terms of course) set everything up to pull fastlane along (including the description) with the next release. Thanks a lot!

[prateekmedia]

@IzzySoft I know, that's why I have updated the pubspec.

I deleted the previous release and created a new one just for that, can you check

https://github.com/prateekmedia/pstube/commit/71e992f8ad6968387ecfca3c9aea97494cb0ffce

[IzzySoft]

The full_description.txt won't render properly as there's a line break missing. You introduced another line right in front of the bullet-point list which, as it's not separated by an empty line, turns that block into a single paragraph. Will not look good. Can you please fix that (ideally before today's update checker run around 5:20 pm UTC)? Suggestion:

Ever wondered how the videos in the internet look without ads, no more wondering here comes your savior.

<b>Features:</b>

* Beautiful user interface
* Lightweight and fast
* No Login Required
* Keep your liked videos and comments
* Playlists support
* Download videos, audios and thumbnails