liquid-route icon indicating copy to clipboard operation
liquid-route copied to clipboard

Published 20 hours ago • verified publisher icon prateekbh

Animation is reversed the second time it runs

Open kanzelm3 opened this issue 7 years ago • 2 comments

I'm curious why you added the reversed animation on exit animation finish: https://github.com/prateekbh/liquid-route/blob/master/Components/LiquidRoute/LiquidAnimator.jsx#L37

It is causing a bug for me where my route transition is messed up/reversed every other time it runs. I removed the reverse animation logic in componentWillLeave and it fixes the issue. Curious if anyone else is seeing this as it seems to be a pretty big bug. I'll go ahead and submit a PR.

kanzelm3 avatar Jul 15 '17 02:07 kanzelm3

merged 🎉 🎉 🎉 🎉

prateekbh avatar Jul 17 '17 05:07 prateekbh

@kanzelm3 i tested with the current routes, so the idea with reversing is to bring the DOM nodes back into initial position before they are removed. So the same animation can be applied.

Have you built a custom animator for your example? If yes, can I have a look?

prateekbh avatar Jul 18 '17 05:07 prateekbh