prataprc

Results 48 comments of prataprc

> Having Node here lets us keep a hold of any schema type information when we pass that value around! Any pointers, say in goland, where to find the schema...

We can add the following methods to the `Node interface{}`. ```rust trait Node { fn as_key Option(&'a self) -> Option(&'a self) -> Box

Keeping the `Kind`, `Basic` types as it is [from the earlier comment](https://github.com/ipld/specs/issues/323#issuecomment-714550392), `Key` type and `Node` trait is updated as follows. ```rust pub enum Key { Bool(bool), Offset(usize), Text(String), Bytes(Vec),...

@vmx Thanks for bringing it up. If `Text(String)` needs to be `Text(Vec)`, can we use `Bytes(Vec)` ? The way I understood: * While reading from codec, if codec calls it...

> Yes. I think this is how it would need to be done. I had hoped the Data Model could just define Strings being valid Unicode. I am using std::str::from_utf8_unchecked()...

Not that I am expert in git-workflow.. but workflow seem to be good. We will merge it. Btw, I am seeing some modifications to Cargo.toml and bench-code. May be rustfmt...

Its okay if it is not fmt standard. We can fix it later. As long as functionality and benchmarks work, we are okay. May be only think you may want...

There are many types of serialization formats. IMHO SerDe wants to Serialize any Rust type to any of those serialization formats. In this case, I think, we only need binary...

https://lemire.me/blog/2019/12/19/xor-filters-faster-and-smaller-than-bloom-filters/ ^ blog post five some idea about serializing the filter.

> Feel free to use that implementation, or we can even merge these two libraries. Let me know what you think. @ayazhafiz thanks for the offer, will give a shout-out...