titanium-imagepicker icon indicating copy to clipboard operation
titanium-imagepicker copied to clipboard

ios 13 support

Open zainesmail opened this issue 6 years ago • 19 comments

How do I compile this for it to be supported in ios 13?

zainesmail avatar Nov 04 '19 19:11 zainesmail

I just tried the version 2.0.0 for iOS and the app compiles fine but just hangs at startup

jwogan5 avatar Nov 18 '19 22:11 jwogan5

Dyld Error Message: Library not loaded: @rpath/libswiftAVFoundation.dylib Referenced from: /Users/USER/Library/Developer/CoreSimulator/Devices/FE3824A0-D493-4838-A181-51871B86AC40/data/Containers/Bundle/Application/DCEA267B-4343-4CEF-A615-49EA73566EFB/TraderTraxx.app/Frameworks/TiImagepicker.framework/TiImagepicker Reason: image not found

jwogan5 avatar Nov 18 '19 22:11 jwogan5

Which titanium SDK are you using? @jwogan5

zainesmail avatar Nov 20 '19 13:11 zainesmail

I was able to get this working today. I had to build it myself and turn on the flag in xcode to add swift libraries and then I had to also embed the frameworks in xcode. After that it finally built the app and ran fine.

jwogan5 avatar Dec 06 '19 01:12 jwogan5

@jwogan5 could you please send me the builded module I'm facing same issue here :) :)

Yazany6b avatar Dec 19 '19 14:12 Yazany6b

Sure, I didn't want some of the functionality in the module such as ability to take photos or videos and the add filters to photos section after the initial selection of the photos, so in my module I added the code to remove those.

Do you want the module as I have which really is just an image picker or do you want the full module with my changes removed?

jwogan5 avatar Dec 19 '19 16:12 jwogan5

This is my module stripped down to just the image picker part.

https://github.com/jwogan5/jwogan5.github.io/blob/master/ti.imagepicker-iphone-2.1.0.zip

If you want full module let me know?

jwogan5 avatar Dec 19 '19 16:12 jwogan5

@jwogan5 Thanks alot I need only the image picker functionality nothing else, I'm using the module you provided and its working as expected, Thanks Again.

Yazany6b avatar Dec 20 '19 17:12 Yazany6b

@jwogan5 When trying to distribute the app for test flight it shows the following error Screen Shot 2019-12-21 at 4 58 48 AM

Yazany6b avatar Dec 21 '19 03:12 Yazany6b

@Yazany6b

I figured the issue out and built a new module. This one will upload to the store as I uploaded my app to the store to test it.

I also renamed the version to 2.0.1 so run the following before installing the module.

rm -rf ~/home/Library/Application Support/Titanium/modules/iphone/ti.imagepicker/2.1.0

The new module is : https://github.com/jwogan5/jwogan5.github.io/blob/master/ti.imagepicker-iphone-2.0.1.zip

jwogan5 avatar Dec 22 '19 00:12 jwogan5

@jwogan5

Thanks it worked thank you very muuuuuch, by the way I have developed about 16+ mobile apps using titanium if you needed any help with anything please contact me though my email [email protected], Thanks a lot again.

Yazany6b avatar Dec 23 '19 17:12 Yazany6b

@Yazany6b

I just built a new 2.0.2 version of the module that has the newest releases of all the included frameworks. This includes a fix for dark mode support where when in dark mode the close text is visible instead of black text on a black background. Let me know if you need it.

jwogan5 avatar Jan 05 '20 05:01 jwogan5

@jwogan5 I need it 🙂 Do you have a public repo with your code?

AnthonyNjuguna avatar Feb 21 '20 09:02 AnthonyNjuguna

I need it too! Thanks 😊

macasfaj avatar Feb 21 '20 10:02 macasfaj

https://github.com/jwogan5/jwogan5.github.io/blob/master/ti.imagepicker-iphone-2.0.3.zip

Latest libraries of YPImagePicker.

jwogan5 avatar Feb 21 '20 19:02 jwogan5

@jwogan5 Thanks for the complied version. Would you be willing to share your source code?

ndynamite avatar Mar 02 '20 17:03 ndynamite

@ndynamite

Basically, all I did was hardcode some values in the TiImagePickerModule.swift file because I wanted it to behave a certain way without making code changes in the main project and creating a PR. If people want these changes I could make a PR for it. I also downloaded carthage and got all that setup so that I could get the newest versions of the library frameworks to work. The current ones in this module did not support the higher versions of swift which is why the module did not work for me. Once I was able to get the newest frameworks in the module everything worked. The zip file I put up above if unzipped you will have the newest versions of the frameworks. You can just take those 3 files and place them into the platform folder and build the module for yourself without my hardcoded changes.

I did not want to have the ability to take photos or filters. I basically just wanted a library image picker. But again just download the current project from this repo. Switch out the platform 3 library files with the ones contained in my zip file. You will then have the most up to date library files in the platform folder. You can then build the project and everything will work.

These are my hardcoded changes in the main swift file.

config.showsPhotoFilters = false config.startOnScreen = .library config.screens = [.library] config.shouldSaveNewPicturesToAlbum = false config.onlySquareImagesFromCamera = false config.hidesBottomBar = true

// General (optional) config
config.library.numberOfItemsInRow = options["columnCount"] as? Int ?? 3
config.library.onlySquare = false
config.library.isSquareByDefault = false
config.library.skipSelectionsGallery = true

jwogan5 avatar Mar 03 '20 17:03 jwogan5

@jwogan5

Thank you for the detailed information Jason! That is very helpful.

I need to make a couple of modifications to TiImagePickerModule.swift myself so I will follow your advice and copy the 3 library files.

Thanks again!

ndynamite avatar Mar 04 '20 15:03 ndynamite

Then you know how to disable the zoomed view at opening of the imagepicker? the preview images always fill the screen and are saved like that. I have to disable this option on start

caspahouzer avatar Apr 14 '20 09:04 caspahouzer