tinyfilemanager icon indicating copy to clipboard operation
tinyfilemanager copied to clipboard

Ace Editor: Add offline assets

Open smalos opened this issue 2 years ago • 6 comments

Ace requires some other files (themes, extensions, syntax highlighting etc.)

It's probably better to place them in a subfolder within assets/js/

and then replace

'js-ace' => '<script src="assets/js/ace.js"></script>',

with

'js-ace' => '<script src="assets/js/ace/ace.js"></script>',

See discussion

smalos avatar Feb 23 '23 12:02 smalos

@prasathmani I submitted the pull request some time ago and I was wondering if you had a chance to review it yet and if there's anything that's unclear or needs clarification. If everything looks good, would it be possible to merge the pull request?

Thank you for your time and consideration.

smalos avatar Mar 20 '23 14:03 smalos

I am also interested in merging this (I need a standalone "independent" deployment).

dumblob avatar Mar 20 '23 20:03 dumblob

It may be worthwhile to inquire whether there is any interest in developing a fully offline version, or whether the pull request should be closed due to the lack of response

smalos avatar May 04 '23 15:05 smalos

I am interested in merging this application in an environment without internet. Thank you

gerese1 avatar May 05 '23 21:05 gerese1

I think it's worth it, but it might also be a good idea to bring the offline branch up to date with the master branch since there is more than a dozen commits in master that have not been pushed to the offline branch.

Edit: there is no conflict with this PR, I proposed https://github.com/prasathmani/tinyfilemanager/pull/1037 since the offline branch is being neglected a bit.

ner00 avatar May 05 '23 23:05 ner00

@smalos I would also encourage updating Ace to the latest version, and mention the version in the commit and PR title so it's easier to track down the line.

ner00 avatar May 06 '23 17:05 ner00