tinyfilemanager icon indicating copy to clipboard operation
tinyfilemanager copied to clipboard

Added ACE's font size and theme variables

Open nerun opened this issue 1 year ago • 0 comments

Setting the font size and theme every single time I edit a file is annoying. This PR address issue #1171.

That issue was about adding global variables to change the ACE editor theme and font size in config.php, the same way it happens in other configurations. PR #1200 only partially solved the issue of the font size not changing when editing tinyfilemanager.php directly.

With this PR I added global constants defined right after the inclusion of the config.php file. Their values ​​are conditional, and depend on whether or not there are variables defined in config.php. The code is super short, and easy to understand, it only changes 4 lines.

If you want to set custom values, just include these lines in config.php:

$ace_fontsize = 18;
$ace_theme = 'dracula';

Default values are 12 and textmate.

I tried using normal global variables instead of using constants, but it didn't work. For some reason when I add <?php echo $variable; ?> to set font size and theme it doesn't work, but when I use constant it works: <?php echo CONSTANT; ?>.

I'm open to suggestions, it's always good to learn.

nerun avatar Jan 27 '25 17:01 nerun