tinyfilemanager icon indicating copy to clipboard operation
tinyfilemanager copied to clipboard

Dynamic Browser Tab Title Handling Based on File Context

Open jabedbd opened this issue 1 year ago • 2 comments

Now it will show the filename as the browser tab title so that the user can easily identify which file is opened on which tab.

jabedbd avatar Jun 30 '24 14:06 jabedbd

For the sake of simplicity, I propose to remove lines 3722 and 3734, then replace line 3733 with:

    echo isset($_GET['edit']) ? $_GET['edit'] : fm_enc(APP_TITLE);

Updated

jabedbd avatar Jul 08 '24 11:07 jabedbd

@jabedbd It's still pending the commented review.

ner00 avatar Jul 25 '24 10:07 ner00

@jabedbd It's still pending the commented review.

Hi, is there anything I can do from my side? i have already updated the code that you mentioned above.

jabedbd avatar Oct 01 '24 04:10 jabedbd

@jabedbd It's still pending the commented review.

Hi, is there anything I can do from my side? i have already updated the code that you mentioned above.

I think so, yes. Remove the trailing space in line 3721, after 'navbar-normal';, that was you who added that space, it did not exist before and doesn't need to be there anyway.

ner00 avatar Oct 01 '24 13:10 ner00

@jabedbd It's still pending the commented review.

Hi, is there anything I can do from my side? i have already updated the code that you mentioned above.

I think so, yes. Remove the trailing space in line 3721, after 'navbar-normal';, that was you who added that space, it did not exist before and doesn't need to be there anyway.

Done. The extra trailing space is removed

jabedbd avatar Oct 01 '24 13:10 jabedbd