tinyfilemanager icon indicating copy to clipboard operation
tinyfilemanager copied to clipboard

Full size error

Open acastrovargas opened this issue 1 year ago • 7 comments

The full size is not real, it only shows the value of files and not the contents in the folders.

CinNg8j

acastrovargas avatar Jan 15 '24 02:01 acastrovargas

#1100 Check out this PR, as it implements a feature to display disk space usage.

explorerfaketimepass avatar Jan 24 '24 16:01 explorerfaketimepass

The PR is still not integrated?

acastrovargas avatar Jan 24 '24 17:01 acastrovargas

Just note that the script will have to iterate through every sub-folder and its contents to calculate this, every time the page refreshes. I had implemented this on a custom version of mine but had to turn if off due to the performance impact. If you have few files and all with a certain acceptable size, no problem, otherwise the HDD will be taxed immensely.

ner00 avatar Jan 24 '24 18:01 ner00

Thanks, I was about to implement, for this reason I will not do it

acastrovargas avatar Jan 24 '24 18:01 acastrovargas

@ner00 No, the script does not iterate through every sub-folder and its contents to calculate disk space. It uses efficient built-in PHP functions (disk_total_space() and disk_free_space()) that directly query the operating system, so it won't heavily tax the HDD.

hppanpaliya avatar Jan 24 '24 18:01 hppanpaliya

@hppanpaliya my misunderstanding then, I was thinking of folder ~file~ size, which is obviously different and that does have to work in the way I described.

ner00 avatar Jan 24 '24 18:01 ner00

acastrovargas avatar Jan 24 '24 18:01 acastrovargas