hyprdots icon indicating copy to clipboard operation
hyprdots copied to clipboard

update rounding corners in wbarstylegen.sh

Open rishav12s opened this issue 1 year ago • 4 comments

Pull Request

Description

Please read these instructions and remove unnecessary text.

  • Fixes the rounding corners when rounding is commented out in hypr.theme

Type of change

Please put an x in the boxes that apply:

  • [x] Bug fix (non-breaking change which fixes an issue)
  • [x] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [ ] Documentation update (non-breaking change; modified files are limited to the documentations)
  • [ ] Technical debt (a code change that does not fix a bug or add a feature but makes something clearer for devs)
  • [ ] Other (provide details below)

Checklist

Please put an x in the boxes that apply:

  • [ ] I have read the CONTRIBUTING document.
  • [ ] My code follows the code style of this project.
  • [ ] My commit message follows the commit guidelines.
  • [ ] My change requires a change to the documentation.
  • [ ] I have updated the documentation accordingly.
  • [ ] I have added a changelog entry.
  • [ ] I have added necessary comments/documentation to my code.
  • [ ] I have added tests to cover my changes.
  • [ ] I have tested my code locally and it works as expected.
  • [ ] All new and existing tests passed.

Screenshots

(if appropriate)

Additional context

Add any other context about the problem here.

rishav12s avatar Nov 28 '24 15:11 rishav12s

Did you test this?

I'm using a fork so maybe I'm doing something different

kRHYME7 avatar Nov 28 '24 16:11 kRHYME7

switching from a commented rounding theme to rounding theme makes waybar 0 round

ig it needs improvement/changes will have to check

rishav12s avatar Nov 28 '24 16:11 rishav12s

race conditions, that's why we needed to parse the hypr.theme.


hypr_border=$(awk -F '=' '{if($1~" rounding ") print $2}' $src_file | sed 's/ //g')
 if [ "$hypr_border" == "0"  ] || [ -z "$hypr_border" ] ; then 
     sed -i "/border-radius: /c\    border-radius: 0px;" "$out_file" 
  fi

Try this one

kRHYME7 avatar Nov 28 '24 16:11 kRHYME7

race conditions, that's why we needed to parse the hypr.theme.


hypr_border=$(awk -F '=' '{if($1~" rounding ") print $2}' $src_file | sed 's/ //g')
 if [ "$hypr_border" == "0"  ] || [ -z "$hypr_border" ] ; then 
     sed -i "/border-radius: /c\    border-radius: 0px;" "$out_file" 
  fi

Try this one

this one works but i think the default one was good with waybar not rounding when commenting out rounding in hypr.theme if we can have seperate rounding variables in waybar and rofi .theme then it be better (if rounding not mentioned in them then follow hypr.theme) and as wlogout follows waybar theming it would also follow that

rishav12s avatar Nov 29 '24 05:11 rishav12s