replace pokemon-colorscripts with pokeget
Pull Request
Description
- Replace pokemon-colorscripts-git with pokeget-rs because its rust, actively maintained, faster,etc.....
- https://github.com/talwat/pokeget-rs
Type of change
Please put an x in the boxes that apply:
- [x] Bug fix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] Documentation update (non-breaking change; modified files are limited to the documentations)
- [ ] Technical debt (a code change that does not fix a bug or add a feature but makes something clearer for devs)
- [ ] Other (provide details below)
Checklist
Please put an x in the boxes that apply:
- [x] I have read the CONTRIBUTING document.
- [x] My code follows the code style of this project.
- [x] My commit message follows the commit guidelines.
- [ ] My change requires a change to the documentation.
- [ ] I have updated the documentation accordingly.
- [ ] I have added a changelog entry.
- [ ] I have added necessary comments/documentation to my code.
- [ ] I have added tests to cover my changes.
- [ ] I have tested my code locally and it works as expected.
- [ ] All new and existing tests passed.
Screenshots
Additional context
pokeget vs other similar project
pokeget vs pokemon-colorscripts
LGTM here is a comparision
Pokeget
Pokemon scripts
Pokeget sure looks faster nearly 10x
So I published my rewrite on aur and its backward compatible with the pokemon scripts. Also the rust build takes a lot time comparatively . It matches the speed of the rust and will be receiving updates and features ,
Perhaps we can switch to this?
https://github.com/rubiin/pokego
Will be adding a bin version too
@rubiin looks good but is compilation time that much of a factor ?
sure go is compiled faster but i dont think it will make that much of difference as the rust one should be like 30 secs or a minute more
another thing i noticed (again a very minor difference) that the package size is bigger for pokego (40+ mb) while pokeget is 4mb
i read that the sprites need to stored locally or something for pokemon-colorscripts ig thats why the difference
@rishav12s thats fixed. Its now 5 mb
@rubiin nice its a 50-50 decision ig now
lets see what khing has to say on this one
then i will get the changes done accordingly
I trimmed down to 5mb lol :D Basically sprites are packaged within the app so that was causing the size spike.
Honestly if this launches kitty faster 🤙. Cause there’s already a delay where if you start typing right after you hit super Q. Half your text is above the line
@abenezerw sadly this wont be merged anytime soon as khing said that the installation packages should be according to tittu's preferences as it is his dotfiles
for now ig you can get the packages and manually replace the command in .zshrc
I'll confirm that.
How about we make a repo similar to this or a wiki https://github.com/hyprland-community/awesome-hyprland
Having good defaults is good but again this is not my repo and we already have a working defaults. I would suggest we can wrap around HyDE with things that can extend its functionality.
@kRHYME7 added a sample page . we can add more stuffs https://hydeproject.pages.dev/reference/tools/
So I want to join. 😄
I guess time command works different on each device so this is pokego vs puke
Just wanted to join the fun. As I'm learning Go, I tried porting it to cpp.
but fk cpp no std for embed!
Edit: Added hyperfines benchmark
And in release build