react-diff-viewer icon indicating copy to clipboard operation
react-diff-viewer copied to clipboard

chore: update Peer Dependencies for React

Open feddyups opened this issue 3 years ago • 12 comments

Update Peer Dependencies for React

feddyups avatar Jun 09 '21 09:06 feddyups

Tests pass locally when using React 17, though you have to install @wojtekmaj/enzyme-adapter-react-17 as an enzyme adapter in order to get them to work. (Enzyme doesn't yet officially support React 17).

schmave avatar Jun 23 '21 18:06 schmave

Hi team,

What is blocking this change?

yeikel avatar Oct 18 '21 19:10 yeikel

approval as a subtle nudge ;)

kad-stokkt avatar Nov 18 '21 14:11 kad-stokkt

up

iamursky avatar Dec 27 '21 22:12 iamursky

Is this project still alive? Should we try with a fork or something? Ideally before we move to React 18?

feddyups avatar Jan 10 '22 20:01 feddyups

Come on guys! Let's merge this thing :) A lot of people need it.

plamenkoyovchev avatar Jan 17 '22 08:01 plamenkoyovchev

+1

stsmurf avatar Feb 02 '22 19:02 stsmurf

+1

iamursky avatar May 13 '22 11:05 iamursky

@praneshr could you please merge this PR?

nimesulide avatar Jun 07 '22 10:06 nimesulide

Hello @praneshr . I've been using this library with React 17 for months now and I can confirm it works fine. I would be glad to help you if there is still anything missing to merge this PR. How may I help?

nagarciah avatar Jun 21 '22 10:06 nagarciah

Hi, guys, what about merge and closing this issue?

nnikitos95 avatar Jul 29 '22 12:07 nnikitos95

Hi, any estimation on when this issue will be resolved?

talSofer avatar Aug 22 '22 10:08 talSofer