react-diff-viewer icon indicating copy to clipboard operation
react-diff-viewer copied to clipboard

is there any plan to upgrade react dependency to 17 ?

Open passos opened this issue 3 years ago • 11 comments

the library now depends on react 15 & 16. it doesn't work under react 17. I am wondering is there any plan to upgrade the dependency?

passos avatar Apr 25 '21 13:04 passos

Maybe some can help out here if they have ideas?

rushi avatar May 29 '21 03:05 rushi

Hello,

Is this just a matter of adding ^17.0.0 in the peerDependencies or something more than that?

	"peerDependencies": {
		"react": "^15.3.0 || ^16.0.0 || ^17.0.0",
		"react-dom": "^15.3.0 || ^16.0.0 || ^17.0.0"
	},

ramkumarkb avatar Jun 01 '21 15:06 ramkumarkb

yes @ramkumarkb, https://github.com/praneshr/react-diff-viewer/pull/125/files

feddyups avatar Jun 09 '21 09:06 feddyups

Is there any progress on updating to support react 17? I noticed the last release was a year ago so I'm wondering the project is active?

tenacioustechie avatar Jul 27 '21 08:07 tenacioustechie

Bump - we need this to correct an issue with legacy peer dependencies in Payload.

Can we get the above PR merged in? Everything appears to work with React 17.

jmikrut avatar Feb 06 '22 20:02 jmikrut

it doesnt feel like the project is active, I am considering forking this...

feddyups avatar Mar 17 '22 11:03 feddyups

I would help test/contribute if you do @feddyups

tenacioustechie avatar Apr 13 '22 03:04 tenacioustechie

I would also help test/contribute.

jonwardopenai avatar Apr 13 '22 16:04 jonwardopenai

We are using it with react@18 and seems to work fine. Maybe just remove the peerDependencies restriction?

oswaldoacauan avatar Jul 26 '22 07:07 oswaldoacauan

there seem to be multiple forks already now with https://www.npmjs.com/package/react-diff-viewer-continued being the most popular so far. I think I'm considering switching to that fork for now, maybe the community should consider the same / agree on a fork

herndlm avatar Sep 15 '22 12:09 herndlm

Thanks @herndlm

faisal004 avatar Apr 08 '24 08:04 faisal004