Genius.NET icon indicating copy to clipboard operation
Genius.NET copied to clipboard

Published 20 hours ago • verified publisher icon prajjwaldimri

Fixed DeserializationException + improved unit testing

Open OmarPani93 opened this issue 4 years ago • 8 comments

Fixes #20

  • Updated the SongResponse model
  • Improved unit testing: added more tests (testing ArtistClient, SongClient, SearchClient and AnnotationClient)

There are a lot of changes but most of them are related to code indentation performed by CTRL + K, CTRL + D shortcut on Visual Studio so don't worry. I added more tests in order to be sure I didn't break other functionalities. You can run them, if you want, after putting the API key in the App.config file.

OmarPani93 avatar Feb 07 '21 17:02 OmarPani93

Can you set your indentation level to 2 spaces instead of 4? That's the convention I follow. Thanks :)

prajjwaldimri avatar Feb 08 '21 04:02 prajjwaldimri

@prajjwaldimri done.

OmarPani93 avatar Feb 12 '21 22:02 OmarPani93

@OmarPani93 Should I merge this?

prajjwaldimri avatar Feb 15 '21 07:02 prajjwaldimri

@prajjwaldimri if you want you could merge it already. I just want to run more tests, like fetching massive artist and song data, in order to find other problems, if there are. Anyway, yesterday I fetched like 2000 songs with the version you can see in this PR and everything was working.

OmarPani93 avatar Feb 15 '21 08:02 OmarPani93

@OmarPani93 Alright. We'll merge it when you complete your tests.

prajjwaldimri avatar Feb 15 '21 08:02 prajjwaldimri

@OmarPani93 Any updates on the tests?

prajjwaldimri avatar Apr 14 '21 05:04 prajjwaldimri

Hi @prajjwaldimri, sorry for the delay. I have been busy recently. Hopefully I will do the tests in the next couple of weeks. Sorry again.

OmarPani93 avatar Apr 17 '21 16:04 OmarPani93

Hey Omar. No worries. :) Looking forward to merging your changes in the repo.

prajjwaldimri avatar Apr 17 '21 17:04 prajjwaldimri