pragha icon indicating copy to clipboard operation
pragha copied to clipboard

Added a setting to enable mono playback.

Open mvdkwast opened this issue 11 years ago • 4 comments

This adds a setting to the audio preferences that allows for mono playback. This is useful when you only have one speaker, which would normally cause the content of the right track to be lost.

mvdkwast avatar Dec 03 '13 19:12 mvdkwast

Hi @mvdkwast First, thanks for helping!. =)

But a doubt .. When is necessary use mono?. Because a speaker is broke? or is there any real application?. Correct me if I'm wrong.. but currently mono soundcards are not used.. No?.

If you have a stereo soundcard and want to use a single speaker would be more interesting use audioparonama and merge it within the equalizer... (You can get the same directly on pulseaudio.. haha)

http://gstreamer.freedesktop.org/data/doc/gstreamer/head/gst-plugins-good-plugins/html/gst-plugins-good-plugins-audiopanorama.html

p.s: Another thing, be careful with the use of tabs and spaces.. and avoid adding comnits that are not relevant to your pull request!. :sweat_smile:

matiasdelellis avatar Dec 03 '13 20:12 matiasdelellis

Hi,

The mono option is useful when you want to listen to music on a guitar amplifier, to practice for instance. Especially some older albums have instruments hard-panned to one side, which means that sometimes you won't hear the solo you want to practice ! Another usecase is that if you have two speakers that aren't placed nicely aournd the listeners (for lack of space for instance), mono can sound better than stereo.

Mixing left and right to mono is not the same thing as panning the signal to one side which looses part of the signal, and silences a speaker if you have two, so audiopanorama is not an option. I was tired of routing pragha through jackd just to achieve mono sound, and after checking a few players I didn't find any that was so fast and had a library, so I decided to take a look at the source.

I'm not sure the equalizer would be the best place to toggle between mono and stereo because it requires a restart as implemented now, so better keep the audio options together (or implement hot audio restarting, which seems a lot of work for not so much benefit), Also, if you think this option is too much of a niche, by all means leave it out, and keep pragha as lean and mean as it is now :)

Sorry for the commit mess, I'm not very used to git and did not find how to revert those commits to clean them up !

On Tue, Dec 3, 2013 at 9:48 PM, matiasdelellis [email protected]:

Hi @mvdkwast https://github.com/mvdkwast First, thanks for helping!. =)

But a doubt .. When is necessary use mono?. Because a speaker is broke? or is there any real application?. Correct me if I'm wrong.. but currently mono soundcards are not used.. No?.

If you have a stereo soundcard and want to use a single speaker would be more interesting use audioparonama and merge it within the equalizer... (You can get the same directly on pulseaudio.. haha)

http://gstreamer.freedesktop.org/data/doc/gstreamer/head/gst-plugins-good-plugins/html/gst-plugins-good-plugins-audiopanorama.html

p.s: Another thing, be careful with the use of tabs and spaces.. and avoid adding comnits that are not relevant to your pull request!. [image: :sweat_smile:]

— Reply to this email directly or view it on GitHubhttps://github.com/matiasdelellis/pragha/pull/59#issuecomment-29749715 .

mvdkwast avatar Dec 03 '13 21:12 mvdkwast

The mono option is useful when you want to listen to music on a guitar amplifier, to practice for instance. Especially some older albums have instruments hard-panned to one side, which means that sometimes you won't hear the solo you want to practice ! Another usecase is that if you have two speakers that aren't placed nicely aournd the listeners (for lack of space for instance), mono can sound better than stereo.

Ohh.. Ok.. This is a real application where it can be useful.. :blush:

Sorry for the commit mess, I'm not very used to git and did not find how to revert those commits to clean them up !

Do not worry..

Well .. It really is not an intrusive change .. So I invite you to continue working .. :wink:

matiasdelellis avatar Dec 03 '13 21:12 matiasdelellis

ps: Makes all changes based on master!. Not from 1.2, because I will not add functionality there..

matiasdelellis avatar Dec 03 '13 21:12 matiasdelellis