react-responsive-modal
react-responsive-modal copied to clipboard
fix: support for React 18
Adds react 18 to peer dependencies
Published as @huksley/[email protected]
Codecov Report
Base: 95.28% // Head: 95.28% // No change to project coverage :thumbsup:
Coverage data is based on head (
a1222a0
) compared to base (ee57745
). Patch has no changes to coverable lines.
Additional details and impacted files
@@ Coverage Diff @@
## master #498 +/- ##
=======================================
Coverage 95.28% 95.28%
=======================================
Files 6 6
Lines 191 191
Branches 69 69
=======================================
Hits 182 182
Misses 9 9
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
I installed @huksley/[email protected] and it seems like flicker effect still exist, i don't know if it is only for me because im using nextjs
I haven't fixed the flicker in this PR.
In my code which uses react-responsive-modal
I am doing this fix https://github.com/pradel/react-responsive-modal/issues/495#issuecomment-1174789792
I haven't fixed the flicker in this PR.
In my code which uses
react-responsive-modal
I am doing this fix #495 (comment)
I thought you implemented this because of your comment but it, my mistake, but it would be good if this is implemented in the release so there is no need to repeat this code each modal.
Added feature request into Bedrock project https://github.com/Bedrock-Layouts/Bedrock/issues/1355
It seems that React 18 support fixed in 1.3.1 of @bedrock-layout/use-forwarded-ref
@pradel Anything preventing this from being merged upstream to npm? Thanks in advance.
Any updates on this PR? @pradel
Published in 6.4.1, thanks for the pr!