Léo Pradel comments

Results 142 comments of


Léo Pradel

fix(typeorm): make the services attribute consistent with mongodb

@blessanabraham if you have time to add the tests I can create a release after it's merged with the changes :)

Create meteor guide

You can check this gist https://gist.github.com/acomito/b6969d6121254eeffa54be431a3f2262

mongo: store the reset password tokens in a separate collection and use TTL to automatically delete them

@sakulstra iirc meteor is using an internal `setInterval` to delete the sessions

mongo: store the reset password tokens in a separate collection and use TTL to automatically delete them

https://github.com/meteor/meteor/blob/9343ce2a3e6cfe88d591b827f826ee3241f66b3b/packages/accounts-base/accounts_server.js#L1430

mongo: store the reset password tokens in a separate collection and use TTL to automatically delete them

@sakulstra the sessions are stored as a token saved inside the user object and TTL is not working in such case. If they wanted to use it they would have...

AccountsBoost doesn't implement the changes for db or account password

Accounts-boost is not the prefered way to use accounts-js for now, can you try the same with accounts/server and accounts/graphql?

Provide deployed fullstack examples

By deployed do you mean deployed online? Or just to provide a docker-compose file ready for the examples?

feat: transition to graphql-modules v2

Thank you so much for the pr @darkbasic, I will be able to have a look only next week 🙏

feat: transition to graphql-modules v2

@darkbasic I started to review the pr, but the amount of unrelated changes makes it really hard :( Could it possible to split it in multiple prs? eg: 1. upgrade...

feat: transition to graphql-modules v2

@darkbasic I upgraded the deps to limit the number of changes in this pr. > I circumnvented the issue by overriding the bundled graphql-tools version (darkbasic/accounts@f078633/package.json#L75) and it works fine...