practical-nlp-code icon indicating copy to clipboard operation
practical-nlp-code copied to clipboard

Published 20 hours ago • verified publisher icon practical-nlp

[BUG] Mistakes in Ch4/01_OnePipeline_ManyClassifiers.ipynb

Open kgdunn opened this issue 3 years ago • 5 comments

In: Ch4/01_OnePipeline_ManyClassifiers.ipynb

1/ In cell 14, related to SVM: there is a copy/paste error in the comment, referring to Logistic regression, when the code in that cell is only regarding SVM.

2/ The AUC metric calculated here for SVM calculates something, but it is the AUC for the prior cell, for logistic regression. As seen by the duplicated values.

kgdunn avatar Aug 18 '21 21:08 kgdunn

Okay, not sure that went wrong here. Let me look into this over the weekend.

varunp2k avatar Aug 18 '21 23:08 varunp2k

Okay it seems to be an error on our side. @kgdunn would you want to send a pr to fix this?

varunp2k avatar Aug 29 '21 07:08 varunp2k

I'm using your code and notebooks to learn from. I doubt you'd want a PR from me in this context.

On Sun, 29 Aug 2021, 09:58 Varun P, @.***> wrote:

Okay it seems to be an error on our side. @kgdunn https://github.com/kgdunn would you want to send a pr to fix this?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/practical-nlp/practical-nlp-code/issues/75#issuecomment-907747745, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAENGT3VHJBGUTHV3LEYZMLT7HSC7ANCNFSM5CM3H7BQ .

kgdunn avatar Aug 29 '21 08:08 kgdunn

On the contrary, I believe that this would be another learning opportunity.

kartikay-bagla avatar Aug 29 '21 20:08 kartikay-bagla

This issue is resolved in PR #133

Ethan0456 avatar Sep 06 '23 13:09 Ethan0456