practica icon indicating copy to clipboard operation
practica copied to clipboard

Make our libraries share the same eslint configuration

Open goldbergyoni opened this issue 3 years ago • 2 comments

🎯 Goal: - Currently we have 5 libraries and likely to have more. Each lib now has its own eslint + jest config - It could increase the maintainability to have 'inherit' default configuration but also allow overrides

🤔 Things to consider:

  • is there a strong standard for this?
  • Jest has the notion of preset - This encourages to create of a pseudo-package (library) that holds shared config
  • Consider other custom configuration of unknown tools that libraries share (e.g. mutation, codecov, snyk, etc)

goldbergyoni avatar Jul 05 '22 12:07 goldbergyoni

@rluvaton @DanielGluskin @elektronik2k5 Is there a strong standard here?

goldbergyoni avatar Jul 05 '22 12:07 goldbergyoni

Not one which I'm aware of. It is very fragmented:

  • Some tools support declarative configuration inheritance (like eslint and TS).
  • Others don't support it out of the box, but as long as they can be configured via JS, it can be done. Jest and webpack are examples of that.
  • Some tools just don't have this feature at all (editorconfig).

elektronik2k5 avatar Jul 06 '22 07:07 elektronik2k5