QupyRibbon icon indicating copy to clipboard operation
QupyRibbon copied to clipboard

fix issues and apply linting

Open JoostScheffer opened this issue 1 year ago • 1 comments

Hi there,

I wanted to see this working but needed to fix some issues first.

At some places a float was used as the argument for the functions setMaximumHeight, setMinimumHeight and setIconSize. These now need to be int's. So wrapped them in int()'s. Furthermore I sorted all imports and applied linting using ruff and black. I used a max line length to 100 characters.

With this pull request I hope to make your module easier to use for other people using newer versions of PyQt.

Please let me know if something isn't to your liking :)

JoostScheffer avatar Apr 02 '23 20:04 JoostScheffer

Yes its been a while since i made this. I've recently ported it to PyQt6 in another project and there i was forced to also type cast to int. I've moved most of my work to gitlab though. here I haven't committed my upgrade to pyqt6. But i will.

pracedru avatar Aug 26 '23 14:08 pracedru