vim-lsp icon indicating copy to clipboard operation
vim-lsp copied to clipboard

irregular type names for prop_type_add

Open mattn opened this issue 1 year ago • 1 comments

autoload/lsp/ui/vim/folding.vim
31:    silent! call prop_type_add(s:textprop_name, {'bufnr': a:buf, 'priority': lsp#internal#textprop#priority('folding')})

autoload/lsp/internal/ui/quickpick.vim
7:let s:has_proptype = exists('*prop_type_add') && exists('*prop_type_delete')
62:    call prop_type_add('highlight', { 'highlight': 'Directory', 'bufnr': s:state['resultsbufnr'] })

autoload/lsp/internal/semantic.vim
401:        silent! call prop_type_add(l:textprop_type, {

autoload/lsp/internal/inlay_hints.vim
40:        call prop_type_add('vim_lsp_inlay_hint_type', { 'highlight': 'lspInlayHintsType' })
41:        call prop_type_add('vim_lsp_inlay_hint_parameter', { 'highlight': 'lspInlayHintsParameter' })

autoload/lsp/internal/document_highlight.vim
191:        call prop_type_add('vim-lsp-reference-highlight', {

autoload/lsp/internal/diagnostics/virtual_text.vim
57:            call prop_type_add('vim_lsp_LspError_virtual_text', { 'highlight': 'LspErrorVirtualText' })
58:            call prop_type_add('vim_lsp_LspWarning_virtual_text', { 'highlight': 'LspWarningVirtualText' })
59:            call prop_type_add('vim_lsp_LspInformation_virtual_text', { 'highlight': 'LspInformationVirtualText' })
60:            call prop_type_add('vim_lsp_LspHint_virtual_text', { 'highlight': 'LspHintVirtualText' })

autoload/lsp/internal/diagnostics/highlights.vim
43:                call prop_type_add(s:get_prop_type_name(l:severity),
  • I prefer to use vim-lsp- or vim_lsp_ prefix.
  • I prefer to use dash separators.

@prabirshrestha What do you think?

mattn avatar Sep 18 '22 15:09 mattn

ok normalizing all with vim-lsp-. This has been something that has been bothering me too.

prabirshrestha avatar Sep 18 '22 17:09 prabirshrestha

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Jan 07 '23 18:01 stale[bot]