react-chrono icon indicating copy to clipboard operation
react-chrono copied to clipboard

Custom icons is getting messy with `allowDynamicUpdate={true}`

Open talboren opened this issue 1 year ago • 1 comments

Describe the bug Even when setting allowDynamicUpdate={true}, with custom icons - the view gets screwed at some point.

To Reproduce Steps to reproduce the behavior:

  1. Dynamically add new items to timeline with custom icons
  2. See icons order gets messy

Expected behavior Icons should be in the right order

Screenshots https://github.com/user-attachments/assets/89b596d1-49bc-4a6f-b663-05919abdd942

Additional Context The code is available here: https://github.com/keephq/keep/pull/2185/files#diff-405b9bca1d5fc5e600f96781227fb5d59f8abde4eb83d81fc7b4611fd74c07c9

talboren avatar Oct 14 '24 10:10 talboren

Thank you for this awesome library btw!

talboren avatar Oct 14 '24 10:10 talboren

@Kiryous helped me figure out it was just the missing id attribute (which is not documented anywhere :()

talboren avatar Oct 22 '24 08:10 talboren