react-chrono icon indicating copy to clipboard operation
react-chrono copied to clipboard

fix: settimeout trying to scroll when element is undefined

Open arvndvv opened this issue 1 year ago • 1 comments

Description

when using multiple chrono charts in single component, while its loading if we switch tab, it will result in error as shown in screenshot.

image

Additional context

This is caused by the code

setTimeout(() => { const ele = horizontalContentRef.current as HTMLElement; ele.style.scrollBehavior = 'smooth'; ele.scrollLeft += cardLeft - contentLeft + cardWidth / 2 - contentWidth / 2; }, 100);

when the settimeout of some chrono gets executed, the element might be undefined as the page might have changed.

by adding if(ele) condition to make sure the element is present before initiating the scroll, we can solve this issue.


What is the purpose of this pull request?

  • [x] Bug fix
  • [ ] New Feature
  • [ ] Documentation update
  • [ ] Other

Before submitting the PR, please make sure you do the following

  • [x] Read the Contributing Guidelines.
  • [x] Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • [x] Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • [ ] Ideally, include relevant tests that fail without this PR but pass with it.

arvndvv avatar Sep 10 '24 05:09 arvndvv

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-chrono-uc7v ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 15, 2025 4:32am

vercel[bot] avatar Sep 10 '24 05:09 vercel[bot]