react-chrono
react-chrono copied to clipboard
prabhuignoto
add click event handler for title; add read full button in the footer…
The latest updates on your projects. Learn more about Vercel for Git ↗︎
| Name | Status | Preview | Comments | Updated (UTC) |
|---|---|---|---|---|
| react-chrono-uc7v | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Sep 22, 2023 2:28am |
![vercel[bot] avatar](https://avatars.githubusercontent.com/in/8329?v=4 "Published by a pub.dev verified publisher"){kind=small}
@AlSharp thanks for opening the PR. can you describe what is the change actually. i see a read full button next to read more. do you want the text in read more be changed to read full or does it do something different?
why do we need a click handler for the title?
Always please add a detailed description when opening a PR so its clear what we are trying to achieve.
@AlSharp thanks for opening the PR. can you describe what is the change actually. i see a read full button next to read more. do you want the text in read more be changed to read full or does it do something different?
why do we need a click handler for the title?
Always please add a detailed description when opening a PR so its clear what we are trying to achieve.
my guess would be that the title in of itself can be clickable, which would be a nice touch to have when a timeline item has a url, As for the button i guess its just to show the difference (or a option to have to user either or)
In regards to the title being a link, I support the adding(and would like to see) instead of having to create a button for the url to be clickable as the title can serve both functions.
My use case of it would to be having it be able to open a local file path (obsidian file.path to .md file) while still keeping the timeline a clean look to it.
