ra-multiplex icon indicating copy to clipboard operation
ra-multiplex copied to clipboard

feat: adding nix flake support

Open freexploit opened this issue 2 years ago • 5 comments

I want this mostly to add it for my flake devshells, where I setup rust for different versions, and normally I don't have a global rust-analyzer.

freexploit avatar Sep 18 '23 04:09 freexploit

Hi, is it necessary to keep the flake definition in the repository itself? I don't use nix personally and don't have the knowledge to maintain this.

pr2502 avatar Sep 21 '23 16:09 pr2502

Yeah, the flake definition uses git to make the build reproducible. So it is tied to what is commited. If you don't mind I can take care any PR or issue related to it.

freexploit avatar Sep 23 '23 19:09 freexploit

Ok then. Is there anything that can potentially break with unrelated changes that we could add a check to CI for so we know when we break it?

pr2502 avatar Sep 25 '23 09:09 pr2502

Ok then. Is there anything that can potentially break with unrelated changes that we could add a check to CI for so we know when we break it?

Currently I'm just pining version 1.72 and everything else is from the Cargo.toml definition. So it may break when the github action rust stable upgrades the version. I can add a workflow for the nix part.

freexploit avatar Oct 02 '23 21:10 freexploit

Yes, adding a github actions workflow that would check if the flake still works would be ideal.

pr2502 avatar Oct 03 '23 08:10 pr2502

i've since started using nixos myself and now i've added a flake to the repository^^

pr2502 avatar Aug 15 '24 19:08 pr2502