app icon indicating copy to clipboard operation
app copied to clipboard
verified publisher icon pr-triage

Approved label added with 1 approval and 1 change request

Open allout58 opened this issue 5 years ago • 0 comments

Summary

The approved label is added incorrectly when there is one approving review followed by one changes requested review.

Steps to reproduce

  1. Set up branch protections to require 1 (might not be relevant?)
  2. Request 2 reviews
  3. First reviewer approves the changes (should go to PR: partially-approved, which occurs)
  4. Second reviewer requests changes

Pull Request URL

Private repo unfortunately

What is the current bug behavior?

PR: reviewed-approved label is added

What is the expected correct behavior?

PR: reviewed-changes-requested label is added

Relevant logs and/or screenshots

pr-triage-approval-issue

Possible fixes

(If you have any idea to solve the problem, please help us.) Most likely related to #223. I'm willing to take a crack at a PR in the future, but a little busy at the moment.

allout58 avatar Jun 05 '20 14:06 allout58