KE-complex_modifications icon indicating copy to clipboard operation
KE-complex_modifications copied to clipboard

Adds shortcut to open Alacritty terminal

Open dnmellen opened this issue 3 years ago • 3 comments

dnmellen avatar Nov 26 '21 15:11 dnmellen

IMHO, it is better to add this is as another rule in open_terminal_window.json. What do you think?

MuhammedZakir avatar Nov 26 '21 19:11 MuhammedZakir

I tried to do so, but it fails when I try to run make again. The flow of adding a new rule is not very clear in the documentation. I followed the docs the first time and I created a open_alacritty_terminal.json.rb under src/json the first time, then I ran make and it built ok, but now I can't see the .rb file and if I just remove public/json/open_alacritty_terminal.json and modify open_terminal_window.json then the make fails because it still requires me to add open_alacritty_terminal.json in groups.json

dnmellen avatar Nov 26 '21 21:11 dnmellen

It shouldn't. See the GHA ran for a testing PR I made. All the tests passed successfully. I think you may have made some mistakes when you tried to do this.

GHA: https://github.com/MuhammedZakir/KE-complex_modifications/runs/4341823190?check_suite_focus=true PR: https://github.com/MuhammedZakir/KE-complex_modifications/pull/1

MuhammedZakir avatar Nov 27 '21 16:11 MuhammedZakir