vue-filepond icon indicating copy to clipboard operation
vue-filepond copied to clipboard

v6.0.3 change breaks usage with Vite

Open dbruning opened this issue 2 years ago • 5 comments

Is there an existing issue for this?

  • [X] I have searched the existing issues

Have you updated Vue FilePond, FilePond, and all plugins?

  • [X] I have updated FilePond and its plugins

Describe the bug

To fix #122 vue-filepond v6.0.3 introduced a change to replace: import Vue from 'vue' with: import Vue from 'vue/dist/vue.esm';

Unfortunately this fix breaks the usage of vue-filepond under vite. It causes Vite to include a complete new copy of Vue, which basically re-introduces exactly the problem that #122 was trying to solve ("$attrs is readonly")

The workaround is just to go back to v6.0.2 under Vite. I'm not knowledgeable enough to know how to make a change that will work under both vue-clie(/webpack) and Vite; but hopefully this will help someone in future.

Reproduction

Try to use vue-filepond with vue2 and vite

Environment

- Device: Windows PC
- OS: Windows
- Browser: any
- Vue version: 2.6.14

dbruning avatar Jun 22 '22 22:06 dbruning

I just ran into the same issue

simonmaass avatar Jul 03 '22 19:07 simonmaass

I'm currently working on a new version of FilePond and will also re-visit types.

rikschennink avatar Jul 04 '22 09:07 rikschennink

any news?

smortexa avatar Aug 19 '22 18:08 smortexa

@rikschennink Thank you, Is there any news and it will be great if you support TS completely.

productdevbook avatar Dec 15 '22 13:12 productdevbook

I'll be using JSDoc comments for v5, I believe that is compatible with TS

rikschennink avatar Dec 15 '22 17:12 rikschennink