filepond icon indicating copy to clipboard operation
filepond copied to clipboard

Incorrect use of <label for=FORM_ELEMENT>

Open syzexecutive opened this issue 1 year ago • 7 comments

Is there an existing issue for this?

  • [x] I have searched the existing issues

Have you updated FilePond and its plugins?

  • [x] I have updated FilePond and its plugins

Describe the bug

Incorrect use of label for=FORM_ELEMENT

Chrome Issues shows this error. I think it's because FilePond creates a DIV with "filepond--drop-label" class and puts the label for the file input inside it. Shouldn't the label and input be together?

Reproduction

FilePond sets file input class to filepond--browser and sets random id for it and creates a DIV with "filepond--drop-label" class and puts the label for the file input inside it.

Screenshot 2023-08-19 090827

Issues tab on Chrome:

Screenshot 2023-08-19 090716

Environment

- Device: PC
- OS: Windows 11
- Browser: Chrome 116

syzexecutive avatar Aug 19 '23 05:08 syzexecutive

It points to an input, I don't see what's wrong with that?

rikschennink avatar Aug 19 '23 14:08 rikschennink

Yes, it points, but Chrome issues tab shows this error! How can I solve this? I have nothing special in FilePond config and configured with basics.

syzexecutive avatar Aug 23 '23 05:08 syzexecutive

@syzexecutive Perhaps it's a Chrome bug, I wouldn't worry about it.

rikschennink avatar Aug 23 '23 11:08 rikschennink

It is not a Chrome bug. form and id need to match and they do not. This error (recently) shows differently in various browsers.

This causes uploading reliability and accessibility issues.

CelticParser avatar Sep 29 '23 14:09 CelticParser

@CelticParser But they do seem to match up?

CleanShot 2023-09-29 at 11 08 56@2x

rikschennink avatar Sep 29 '23 15:09 rikschennink

very weird... I get the same error... but not everytime...

image

simonmaass avatar Mar 01 '24 09:03 simonmaass

Seems like a bug in Chrome? The id is clearly there.

rikschennink avatar Mar 01 '24 12:03 rikschennink