filepond icon indicating copy to clipboard operation
filepond copied to clipboard

Possible to add separate svg icon property for revert and remove?

Open timojuonoja opened this issue 2 years ago • 5 comments

Is your feature request related to a problem? Please describe. FilePond has svg icon property for removing, named iconRemove. This icon is used in both removing (for example wrong mime type validation error) and reverting (for example for removing uploaded file).

Describe the solution you'd like Is it possible to have different icon for revert and remove? Like iconRemove and iconRevert or something like that? This feature request or proposal is due to our scenario wants to use different icon for these actions. Hopefully this is at least considered :)

timojuonoja avatar Oct 09 '21 17:10 timojuonoja

This feature request or proposal is due to our scenario wants to use different icon for these actions.

What is the reason for wanting different icons? They are currently the same as for the end user the end result is the same.

rikschennink avatar Oct 18 '21 06:10 rikschennink

The are conceived as two different things (and actually are two different things). Like for instance the example that I used, so failed ones are in that sense "ignored" and are in some sense only in a list to provide the error message why they failed.

timojuonoja avatar Oct 20 '21 18:10 timojuonoja

I'm not sure I understand, please elaborate, how are they different from the user perspective (who doesn't know anything about uploading files and where files are stored)

rikschennink avatar Oct 21 '21 05:10 rikschennink

In my example, the list shows both failed and successful ones.

By removing the failed one you actually kind of just acknowledge and close the error message. Nothing else, because it is failed and cannot be even retried to upload due to validation error. So in that sense, if there are 2 successful and 1 failed one, the actual count for files is 2 (because only successful matters).

By reverting you actually remove the successful one. And if compared to count definition described like I said, it actually decreases the count of files.

This is wanted by the end users. They conceive this like I try to explain.

timojuonoja avatar Oct 21 '21 07:10 timojuonoja

@timojuonoja thanks for the additional info, I'll give it some thought.

rikschennink avatar Nov 02 '21 06:11 rikschennink