filepond icon indicating copy to clipboard operation
filepond copied to clipboard

Handle long validation message at mobile page width

Open vvtkachenko opened this issue 5 years ago • 12 comments

Hi, it would be nice that filepond could show long validation message at mobile page width.

For example in the CodePen below, if uploaded file is above 1MB - validation message doesnt fit to pond widht and filename is pushed out of pond too. https://codepen.io/vova-tkachenko/pen/QZBobm

Probably such long messages should have 'max-width' set to width of pond fall down to the next line.

vvtkachenko avatar Oct 22 '18 14:10 vvtkachenko

It shouldn't overlap/overflow like that, I'll see if I can fix that first and then introduce a different item layout option that has more room for text.

rikschennink avatar Oct 23 '18 10:10 rikschennink

Support for this would be awesome. I have users uploading multiple files, so on desktop am using

    @media (min-width: 50em) {
        .filepond--item {
            width: calc(33.33% - .5em);
        }
    }

When an error is returned, it isn't constrained (silly length error message used for emphasis): screenshot-digicore test-2019 03 27-12-00-19

Note the 'Upload' and 'Retry' button to the right of the error message are hidden as I have my own upload button which I need users to click.

[Aside: I did this via CSS as setting styleButtonProcessItemPosition to null or false didn't remove them. Is that the best way?]

pbowyer avatar Mar 27 '19 12:03 pbowyer

Yes, this is not good. I'll try to give this some more priority.

rikschennink avatar Mar 27 '19 17:03 rikschennink

I had a play with the CSS but didn't solve it, sorry. My frontend skills are very rusty...

pbowyer avatar Mar 27 '19 22:03 pbowyer

@rikschennink Sorry for chasing, but any chance you can look at this?

pbowyer avatar Jun 18 '19 10:06 pbowyer

facing a similar issue where the whole area to drag and upload a file (grey container) appears throughout the width of the page. adding a CSS file didn't work. saw a similar issue in vue.js where it was corrected but I guess not in react. is somebody else facing any such issue?

utsha1510 avatar Jun 26 '19 10:06 utsha1510

@pbowyer no problem, I'm simply too busy.

This cuts of the text, so at least it doesn't exit the bounding box.

.filepond--file-status {
    overflow: hidden;
    max-width: 50%;
}

For a definitive fix the element should scale in height to make room for the error message, which introduces all kinds of other issues.

rikschennink avatar Jun 27 '19 06:06 rikschennink

Hi @rikschennink Appreciate your work done regards this component! Quick question - is there any investigation/work on this issue?

Thanks!

nikolaidenis avatar Mar 02 '23 14:03 nikolaidenis

@nikolaidenis I'm working on v5 in which I want to address all these kinds of core problems.

rikschennink avatar Mar 06 '23 07:03 rikschennink

How do you think, when will you finish working on version 5?

pon., 6 mar 2023 o 08:39 Rik @.***> napisał(a):

@nikolaidenis https://github.com/nikolaidenis I'm working on v5 in which I want to address all these kinds of core problems.

— Reply to this email directly, view it on GitHub https://github.com/pqina/filepond/issues/150#issuecomment-1455613120, or unsubscribe https://github.com/notifications/unsubscribe-auth/AN4DNFFPLIKY3QF2WWNNCIDW2WICRANCNFSM4F6N7OPQ . You are receiving this because you are subscribed to this thread.Message ID: @.***>

-- Pozdrawiam Marcin Kaźmierczak

mrkazmierczak avatar Mar 06 '23 07:03 mrkazmierczak

Honestly no idea. Hope before summer.

rikschennink avatar Mar 06 '23 07:03 rikschennink

The issue is still relevant, latest filepond version (as of 2023-11-05) is 4.30.4

image

juokavom avatar Nov 05 '23 09:11 juokavom