kyber icon indicating copy to clipboard operation
kyber copied to clipboard

Why are you using GAS?

Open QRCS-CORP opened this issue 3 years ago • 2 comments

Congrats on making it to round 3!

Many modern compilers no longer support this old AT&T style dialect, but all the major compilers including GCC and Clang, support the more modern Intel syntax used in MASM. Windows servers are a huge piece of the market, and the go-to tool for Windows programming is Visual Studio, which does not support this older syntax. As a result, a number of downstream prototyping libraries, including my own, have not implemented the AVX versions of these codes. Please consider changing the ASM to the Intel syntax in Dilithium and Kyber, it would save a lot of people a lot of work.

Cheers, John

QRCS-CORP avatar Jun 24 '21 19:06 QRCS-CORP

We have a NASM version of the assembly code:

https://github.com/Argyle-Software/kyber/tree/master/src/avx2/nasm

mberry avatar Jan 09 '23 04:01 mberry

Intrinsic version instead of gas/nasm - would be good also, for using same code both in windows and *nix.

YuriMyakotin avatar Aug 23 '23 19:08 YuriMyakotin