osu icon indicating copy to clipboard operation
osu copied to clipboard

Ability to disable/toggle mods during replays

Open Joehuu opened this issue 4 years ago • 4 comments

Stable already does double time/half time and flashlight, but lazer can probably have more mods to disable during replays (i.e. hard rock, hidden, etc.).

Joehuu avatar Mar 19 '20 05:03 Joehuu

Should be a relatively simple implementation, but will require reinitialisation of some elements of Player so needs to be treated with care.

peppy avatar Mar 21 '20 18:03 peppy

branch

https://user-images.githubusercontent.com/34775378/186041729-68a559c0-3c1f-4db9-b4f2-88789e0b1136.mp4

this is design fine?

All that's left is ~~replayLoaded detection~~ and unit testing

I added an interface named IApplicableToDisable for which mod can be disabled in replay

cdwcgt avatar Aug 23 '22 00:08 cdwcgt

It looks okay, but that interface name sounds weird.

How about ICanBeToggledDuringReplay or similar?

peppy avatar Aug 23 '22 01:08 peppy

of course I'll open a pr if I think its done

cdwcgt avatar Aug 23 '22 03:08 cdwcgt