osu icon indicating copy to clipboard operation
osu copied to clipboard

Points of failure on the details tab goes out of screen when UI scaling is set above 1

Open 59xa opened this issue 6 years ago • 7 comments

Points of Failure can’t be seen properly in the details tab when UI Scale is set above 1. Image: GitHawk Upload by dscnnctd Specific device: iPhone 7 This might happen on PC as well.

59xa avatar Jun 06 '19 04:06 59xa

I have noticed this, where the graph actually inverts. The solution is likely going to involve some reorganising of ScrollContainers, such as making the entire Details tab contents scrollable rather than just the description/tags.

swoolcock avatar Jun 06 '19 05:06 swoolcock

This is more of a UX/UI comment rather than on the actual implementation of this - but in my opinion the entire details tab is redundant & the information is better held elsewhere (Failure rate is generally useless for most players & can instead be shown just on the webiste), the Difficulty specific info should be elsewhere to allow the viewing of the Leaderboards at the same time as the difficulty specific setup info (AR/CS...)

Glycogenesis avatar Aug 12 '19 12:08 Glycogenesis

This does not happen on 2022.509.0. I'm on Ubuntu 20.04

KisaragiEffective avatar May 20 '22 04:05 KisaragiEffective

Tested and it does still happen.

smoogipoo avatar May 20 '22 04:05 smoogipoo

Can verify, still occurs 2022.509.0image

59xa avatar May 20 '22 04:05 59xa

This is still a problem in v2, but it goes out of the screen instead of reducing height to 0.

A solution is making the whole thing a scroll container (as nothing else scrolls), but seems to simple that I may be missing something during the implementation process?

Joehuu avatar Jun 11 '25 01:06 Joehuu

There totally needs to be a different mode of display when the UI scale is higher than normal. This will likely be how the screen is displayed on mobile platforms:

Image

At the very least, we could consider pushing the title wedge upwards away from the screen, and displaying the play/favourites/length/bpm statistics next to the difficulty line or somewhere else in a smaller size.

cc @arflyte (how should the song select screen be displayed on mobile?)

frenzibyte avatar Jun 14 '25 14:06 frenzibyte

@vatei maybe you can give some feedback/direction here. probably involves hiding certain less-important elements when they won't fit height wise, or adjusting global scale of elements on screen.

peppy avatar Jun 18 '25 07:06 peppy

In my opinion, info in the top portion of the wedge are pretty much important except maybe the played and favorite counts, and the advanced map info like circle, spinner, slider count etc. I would instead reduce the details panel, maybe like so:

Image The default date would be "Submitted" unless the map is ranked, then it would show the "Ranked" on, as pictured on this mockup.

As a suggestion, maybe swiping right could reveal another page with the rest of the info?

Image

At the very least, we could consider pushing the title wedge upwards away from the screen, and displaying the play/favourites/length/bpm statistics next to the difficulty line or somewhere else in a smaller size.

Partial agree on length/bpm stats, Maybe next to the main stats (hp, cs, etc)? I would actually completely hide circle count and such too imo. 10s montage of what it would look like

Image

Finally, maybe squishing vertically the charts would get us even more space.

And btw here's what it currently looks like on my 6.8in s23 ultra:

Image The situation looks pretty dire here, even with a big screen like mine :/ The screenshot can't convey how small and cramped it feels on an actual phone but it's not great (and don't even look at global leaderboard)

vatei avatar Jun 18 '25 18:06 vatei

Responding to the above:

  • Placing user/mapper tags as not a whole line doesn't seem like it would work great. Usually wherever tags are displayed, they're given plenty of space.
  • Splitting the entire wedge into two sections through swiping (or simply a tab control) might work well, but I would make the second section dedicated to user/mapper tags, so that each can have its own line.
  • Placing the length/bpm stats in the same area as the difficulty attributes in a sheared manner looks odd and probably painful to make work in code, it's also reducing space for the attributes.

Here's my own (initial) take on song select for mobile (screenshot taken on iPhone 16 via simulator):

Image Image

Of note:

  • The title wedge is immensely compressed, displaying title and artist in a single line with medium font size, and the play count and favourites statistics on the right hand of the wedge, while the length and BPM statistics are placed down on the right hand of the difficulty name line.
    • Anchoring BPM statistic to the right side of a container is usually bad, since its text length varies from short to long. But the sacrifice needs to be made here for the sake of good and consistent visuals.
  • The mapper tag line is temporarily removed, with the intention of bringing it back in a second section of the details area that can be switched to through a tab control.
  • The "points of failure" wedge is vertically resized depending on available height.

Further feedback is welcome.

frenzibyte avatar Jun 20 '25 00:06 frenzibyte

I'm mostly okay with the changes except the song title. It really needs to be bigger. I wouldn't mind sacrificing play count and favorite count to make it more prominent to be honest

vatei avatar Jun 23 '25 00:06 vatei

I've had the title and artist at Heading2, bumping to Heading1 will eat a lot of space. Removing play count and favourite statistics is not an option.

Image

frenzibyte avatar Jun 23 '25 03:06 frenzibyte

I don't mind either version, but in the latter (larger size title) it should be bold or something. It looks way too thin compared to everything around it. Also, the playcounts shouldn't have gotten larger alongside it. I'm not sure why you changed those.

peppy avatar Jun 24 '25 06:06 peppy

The scale of the statistics in the latter actually matches master, while in the former I've manually downscaled it to not be bigger than the title/artist text.

frenzibyte avatar Jun 24 '25 06:06 frenzibyte