Holding CTRL to speed up metronome on 1/1 and triplet divisors has incorrect behavior
Type
Game behaviour
Bug description
When using 1/1 divisor holding CTRL to speed up the metronome does absolutely nothing,
Also when using triplet divisors holding CTRL to speed up the metronome the major tick sounds play on the wrong spot, seemingly behaving as if using a common divisor (image as a clearer example along with video)
Screenshots or videos
1/1 example
https://github.com/user-attachments/assets/addf368e-8d78-42d2-a1af-150c4e6c193d
triplet example
https://github.com/user-attachments/assets/586df865-f535-45c7-b4b0-aa39f10028c1
triplet image example of where major ticks play and where they should actually play
Version
v2025.1121.0-tachyon
Logs
When using 1/1 divisor holding CTRL to speed up the metronome does absolutely nothing,
I'm not fixing this personally because this seems fine? If the song is snapped to 1/1 then you don't know if it's common time or waltz time. Would you have the game just guess?
Actually upon looking at this I could also argue that the "correct" behaviour would be this instead:
Not sure which one makes sense the most. The current behaviour is definitely amusical though.
Actually upon looking at this I could also argue that the "correct" behaviour would be this instead:
Not sure which one makes sense the most. The current behaviour is definitely amusical though.
now that I go this over in my head again this does seem like the more logical way to implement it, however it would be kind of weird (in my own opinion) that speeding up the metronome on common divisors would play the major tick sounds every 2nd white line (which makes sense, as bpm doubles), but then triplets still kept playing them only every 4th one (which is same as non-sped up), but indeed the current points at which the metronome plays is quite distracting when trying to test timing on triplets
however it would be kind of weird (in my own opinion) that speeding up the metronome on common divisors would play the major tick sounds every 2nd white line (which makes sense, as bpm doubles)
No it wouldn't work like that.
The two options I'm considering are:
- major tick sounds are never affected by speedup, they only always play on major bar lines
- major tick sounds are affected by speedup in a way where they play on every white bar line, not just major ones
however it would be kind of weird (in my own opinion) that speeding up the metronome on common divisors would play the major tick sounds every 2nd white line (which makes sense, as bpm doubles)
No it wouldn't work like that.
The two options I'm considering are:
- major tick sounds are never affected by speedup, they only always play on major bar lines
- major tick sounds are affected by speedup in a way where they play on every white bar line, not just major ones
either of these would seem fine / fix the main issue, but also with that part of my message I meant that is how it currently works and not how it should work, sorry if it was worded confusingly.
Not sure which one makes sense the most. The current behaviour is definitely amusical though.