ppy
Maps Reprocessing Star Rating Are Excluded From Star Rating Grouping/Sorting
Type
Cosmetic
Bug description
Problem: Star rating reprocessing removes all maps from being sorted/grouped by star rating even though the old star rating persists visibly in the UI. They all get shoved in a "-1 Stars" group and are unordered.
Why This Matters: Reprocessing star ratings can take hours for me since I have a pretty slow drive and have over 80,000 maps. I don't care about new star ratings so I'd rather just cancel the background process to save on performance as any background processing causes my game to nearly crash when navigating the menu.
Suggested Fix: Always allow maps to be sorted by using the old star rating as a fallback until it has been updated.
Screenshots or videos
"-1 Star" Group with visible old star ratings
Reprocessing Task
Version
2025.1029.1-lazer
Logs
The star ratings are cleared immediately because if you stop the recalculation and close the game and reopen it later, the game can use the fact that the star rating was cleared to know that it needs to recalculate the remaining star ratings.
Therefore not clearing all star ratings immediately at the start would require the diffcalc version to be stored against the beatmap object in the database such that the game can use that as an alternative marker to "no star rating", which will has implications on the realm database size.
On stable, we just negate the star rating when they are being reprocessed. Having a separate flag makes more sense if we want to do-things-right. I wouldn't be against this.
