ppy
Dismiss checking notification when update is found
- Closes https://github.com/ppy/osu/issues/33459
Extremely minor but won't hurt to fix.
Have you tested that this is still a thing after the changes to UpdateManager in https://github.com/ppy/osu/pull/33575? I can tell you for one that this will heavily conflict/not really work after that change, but also I'd hope that it isn't required in the first place.
I don't see anything different in #33575 with regards to the issue at hand. The only other option here is to make the CheckForUpdateAsync function actually only check for updates and split the actual update process to its own function, all such that the "checking for update" notification can be dismissed between those steps.
Right - the second notification is the one that is downloading the update.
I think your proposal of splitting out the process sounds fine. I would rebase on https://github.com/ppy/osu/pull/33575 in any case.
@peppy Before I address the concern above, what are your thoughts between having this PR as-is, and going with the approach proposed in https://github.com/ppy/osu/pull/33645#issuecomment-2963679865 (which will require minor refactor efforts).
I can't understand your message there.
Given that this is likely going to conflict, I'd propose you start by rebasing and/or adjusting as you see fit.
Keep in mind you're dealing with already complicated logic, so if your plan is to refactor the whole world, it will likely end up in the bin.
I'm asking if you're fine with the approach taken in this PR to fix the original issue, or if it's better to go with the proposal of splitting the "check for update" procedure and the "download and install update" procedure so that it become easier to fix the issue.
I'm not sure which of those works better without writing them myself. The logic surrounding updating is complex and I can't give an assessment of that on a whim. See the kinds of issues that can arise in the other PR as an example of why.