Remove button for displaying deleted comments
- Closes https://github.com/ppy/osu/issues/33068
I was initially going to limit this to moderators in a similar manner to web, but we don't have any existing moderator-only features yet, and only having this wouldn't be of much point.
If desired, I can go the other way around and at least accompany this toggle with the ability to delete other comments.
If it's functional, that means the data is still arriving. It sounds like that should first be addressed. If the data isn't arriving, the button could just be hidden rather than removed, for instance, still allowing moderators to use it.
The data is still arriving for non-moderators correct. I'm not sure if this is an intentional choice by the web team to include deleted comments in the API for non-moderators but that's the case right now.
If you still think it should be visible for moderators, I can do that.
cc @ppy/team-web for clarification, seems wrong
it's to allow the replies to be still visible
surely the message should be replaced with an empty string or [deleted] at least?
well yeah that's what it's currently doing
@frenzibyte can you show what this looks like before and after in the client? can you show visually how/if this matches osu-web?
I wasn't aware of the case where replies of a deleted comment should still be visible even to non-moderators (which makes sense, but didn't cross my mind when opening this PR). I'll make this match web more closely.
Before PR:
https://github.com/user-attachments/assets/510451e1-73d8-4cc2-9b68-6a82a21efcad
After PR:
https://github.com/user-attachments/assets/44d4a4a3-8eca-4f77-b0a2-2ed3c225f1d9
Web:
This should now match web.