osu icon indicating copy to clipboard operation
osu copied to clipboard

Fix colour penalties being bypassed via repeated ratio variance

Open Lawtrohux opened this issue 6 months ago • 1 comments

This PR aims to improve the consistentRatioPenalty logic to ensure it cannot be bypassed by spamming 'artificial' ratio changes through offsnaps that can still be hit as a normal 1/4 pattern. This was previously found most egregiously in a test map.

Essentially, whilst preserving original logic, this adds a fallback penalty that checks recent rhythmic ratios, if they're within a predefined average, these fallback into the original logic. This can in some cases nerf colour patterns even more, as its harshened when there are gaps vs a long, sustained 1/4 pattern.

This results in more accurate and abuse-resistant evaluation, without affecting properly varied rhythmically intense maps.

Lawtrohux avatar Jun 11 '25 13:06 Lawtrohux

will also request a smoogisheet for this one to be extra safe @ppy/pp-maintainers, cheers

Lawtrohux avatar Jun 11 '25 13:06 Lawtrohux

!diffcalc RULESET=taiko OSU_A=https://github.com/ppy/osu/tree/pp-dev OSU_B=https://github.com/ppy/osu/pull/33641

stanriders avatar Jun 19 '25 19:06 stanriders

Target: https://github.com/ppy/osu/pull/33641 Spreadsheet: https://docs.google.com/spreadsheets/d/1XKp5Us4RZHoNdpfLbA8j7MN95Y8EVSr96eSU9uTUFKo/edit

github-actions[bot] avatar Jun 19 '25 22:06 github-actions[bot]

values look right to me

buyaspacecube avatar Jul 22 '25 06:07 buyaspacecube