Fix colour penalties being bypassed via repeated ratio variance
This PR aims to improve the consistentRatioPenalty logic to ensure it cannot be bypassed by spamming 'artificial' ratio changes through offsnaps that can still be hit as a normal 1/4 pattern. This was previously found most egregiously in a test map.
Essentially, whilst preserving original logic, this adds a fallback penalty that checks recent rhythmic ratios, if they're within a predefined average, these fallback into the original logic. This can in some cases nerf colour patterns even more, as its harshened when there are gaps vs a long, sustained 1/4 pattern.
This results in more accurate and abuse-resistant evaluation, without affecting properly varied rhythmically intense maps.
will also request a smoogisheet for this one to be extra safe @ppy/pp-maintainers, cheers
!diffcalc RULESET=taiko OSU_A=https://github.com/ppy/osu/tree/pp-dev OSU_B=https://github.com/ppy/osu/pull/33641
Target: https://github.com/ppy/osu/pull/33641 Spreadsheet: https://docs.google.com/spreadsheets/d/1XKp5Us4RZHoNdpfLbA8j7MN95Y8EVSr96eSU9uTUFKo/edit
values look right to me