osu icon indicating copy to clipboard operation
osu copied to clipboard

ensure `monolengthbonus` applies to new strain contribution only

Open Lawtrohux opened this issue 6 months ago • 1 comments

The aim of this PR is correct the application of monoLengthBonus within Stamina.

Mainly, the bonus was applied to the accumulated strain, rather than new strain contribution, causing issues on some maps where removing objects can increase SR due to applying the bonus already decayed notes. This effect was not intended, and whilst isn't a huge issue, should see some difficult mono maps rightfully getting a buff, as well as fixing something actually broken.

Similarly, it disables it inside of singlecolourstamina, in which it would skew values that are displaying for mainly convert-esque maps. This also means that convert values should now display correctly true to their intended values.

Lawtrohux avatar Jun 11 '25 09:06 Lawtrohux

@ppy/pp-maintainers could i grab a smoogisheet for this please? preferably one with converts-only and without. Thank you!

Lawtrohux avatar Jun 11 '25 09:06 Lawtrohux

!diffcalc RULESET=taiko OSU_A=https://github.com/ppy/osu/tree/pp-dev OSU_B=https://github.com/ppy/osu/pull/33635

stanriders avatar Jun 19 '25 20:06 stanriders

Difficulty calculation failed: https://github.com/ppy/osu/actions/runs/15765452591

github-actions[bot] avatar Jun 19 '25 22:06 github-actions[bot]

!diffcalc RULESET=taiko OSU_A=https://github.com/ppy/osu/tree/pp-dev OSU_B=https://github.com/ppy/osu/pull/33635

stanriders avatar Jun 19 '25 22:06 stanriders

Target: https://github.com/ppy/osu/pull/33635 Spreadsheet: https://docs.google.com/spreadsheets/d/19xWuwLERTO-Q8UPaSXoqqI46GzxOPGGDIULtJtAshRc/edit

github-actions[bot] avatar Jun 20 '25 00:06 github-actions[bot]

looks like it!

buyaspacecube avatar Jul 22 '25 06:07 buyaspacecube