osu icon indicating copy to clipboard operation
osu copied to clipboard

Sliders show a glitchy line down the middle of the body texture

Open ghost opened this issue 7 years ago • 14 comments

ghost avatar Aug 13 '18 11:08 ghost

Are you running on linux? Could be a similar issue to #3118.

peppy avatar Aug 13 '18 23:08 peppy

Closing this as fixed.

peppy avatar Sep 06 '18 14:09 peppy

You will need to recompile.

peppy avatar Sep 06 '18 14:09 peppy

Oh, you are on windows? That's an interesting one then. Can you please ensure you are on 2018.906.0?

peppy avatar Sep 06 '18 14:09 peppy

Are you on the latest nvidia drivers?

peppy avatar Sep 06 '18 14:09 peppy

This is not a chat room. Please combine your outgoing text into a single message and refrain from posting "let me check" or similar.

peppy avatar Sep 06 '18 14:09 peppy

If I had to guess that might actually be a divide by zero or corner case vertex alignment issue. It seems to happen when the notes are dead vertical/horizontal, right in the middle. I bet at certain resolutions only those locations line up perfectly with the pixel grid.

marcan avatar Sep 07 '18 11:09 marcan

Looking at the same shader as in #1865, I see v_BlendRange.x is checked for zero in several places, but not in this line. That's a varying, so if the pixels line up right I could see it being exactly 0 in the middle of an object if it's perfectly horizontal or vertical, causing a divide by zero. Long shot maybe, but worth looking into?

marcan avatar Sep 07 '18 11:09 marcan

Potential bug here. Texture.Width is an integer, so the integer division truncates. The texture is set to clamp mode, so it should still render pixels there, but that might be subtly broken on this GPU or driver or something. It's also possible it only breaks for NPOT textures and then only for the right/bottom side, if they are internally padded or clamping only works on POT boundaries, which sounds like the kind of stupid bug some drivers/GPUs could have.

I see more hits for the same pattern. I'm sending in ppy/osu-framework#1881 to fix it.

marcan avatar Sep 07 '18 17:09 marcan

Is this issue still relevant?

TPGPL avatar Sep 15 '18 13:09 TPGPL

@WithoutKnock have you tested on the latest build? A second fix has been merged since the last check with you.

peppy avatar Sep 15 '18 13:09 peppy

On a quick check from @Tom94, the remaining issue may be related to the removal of the epsilon subtraction at https://github.com/marcan/osu-framework/commit/7170c492df1a09438e2b3efcd143ed79e4e67dc0#diff-6ab15dd22923474140a29e6deef5f30cR76. Adding this back in some form may resolve.

peppy avatar Nov 14 '19 06:11 peppy

Please do not rename or close issues without reason.

peppy avatar Apr 19 '20 20:04 peppy

From https://github.com/ppy/osu/discussions/19238 runtime.log


I've ordered a 9800GT to try to reproduce this on.

smoogipoo avatar Jul 20 '22 04:07 smoogipoo