ppy
Adjust the behaviour of resolution number box in tournament client
This PR added a function to the number box of the resolution selector. When the Enter key is pressed with focus on the box, it would save and change the resolution as the Set Height button does.
After the new resolution is applied, a popup would appear for users to confirm the current resolution is what they'd expected.
The number box still keeps focused and receives keyboard input after the resolution change, in case the client window is too big / small (or out of the screen) for users to change values back.
I don't think this is sane. The typical UX is to display a confirmation dialog post-change that requires the user to explicitly confirm they're OK with the change, and if no action is done withing about 20-30 seconds, the previous values are reverted to.
Before reviewing this, where does this requirement come from? It seems very unnecessary to my eye. It's adjusting a window size, not a fullscreen case where a setting could be non-recoverable. It's saving a single click.
The number box still keeps focused and receives keyboard input after the resolution change, in case the client window is too big / small (or out of the screen) for users to change values back.
The original requirement is as above, and to make the UX "typical" I made this popup. And at this point I doesn't know whether we have much demand on this (since such things might happen sometimes).
But saving a click is right btw
On a five minute check I could absolutely get myself in a state where the window gets so large that I can't see the text box after changing resolution in order to undo the change. I could still recover via the titlebar but I'm not sure that will always be universally true either.
I dunno, this seems very edge case to me. Can always be recovered on windows and macOS via OS controls.
I guess I won't say no to this but based on it being a very custom implementation I'm not going to continue with review right now.
Now using a customized dialog implementation seems a little bad to me, thus going to change this. Countdown isn't necessarily needed, only the final result of users accepting the adjusted settings or not.