ppy
Fix difficulty calculator using incorrect OD values
Stable is truncating OD hitwindow, what means that OD9.9 and OD10 are de-facto the same (only 50 hitwindow differs) This means that in reality OD is from 0 to 0.167 higher than game claims.
In this PR this is fixed. OD in accuracy pp is slightly shifted to compensate buffs.
I really dont think this problem is important enough to warrant a PR, considering this issue has been known about for years and nobody really cares about it. At best this will result in a +-3pp difference to the most affected scores.
I really dont think this problem is important enough to warrant a PR, considering this issue has been known about for years and nobody really cares about it. At best this will result in a +-3pp difference to the most affected scores.
actually difference can be quite big, I think it can be up to 20pp on some edgecases (we would know for sure when current rework will be deployed) mrekk save me is +10pp for example and having OD 9, 9.5 and 10 being more "optimal" sounds very silly, I don't want such stupid thing to exist don't see why it shouldn't be merged as a small change in pack with others
actually difference can be quite big, I think up to 20pp on some edgecases mrekk save me is +10pp for example and having OD 9, 9.5 and 10 being more "optimal" sounds very silly, I don't want such stupid thing to exist don't see why it shouldn't be merged as a small change in pack with others
I'll leave it to the PP committee to decide if this is important, but I don't think a 10pp difference on a 1760pp play is of much importance. For context that's half of a percent of the total value.
This looks like something that should be fixed game-wide and not pp-wide, if anything. I also don't think it's worth the code complexity (as in, spending any lines at all) for a negligible difference
This looks like something that should be fixed game-wide and not pp-wide, if anything. I also don't think it's worth the code complexity (as in, spending any lines at all) for a negligible difference
If this PR (https://github.com/ppy/osu/pull/30244) is merged - the issue will be solved automatically Tho it will require some adjustments in the pp code
